theme_comment_folded and theme_comment_wrapper were converted. Most of the functions don't need to be changed.

I changed the parameters for comment_wrapper to include a node. The function that calls it already had it available and I think it can help themers in a big way by providing more context. With that node in place, it also provides a template suggestion based on the parent node type. Garland had an override for the comment wrapper -kinda hackish? and it now uses this new node parameter.

Also added a few bug fixes. A lot of the theme_flat/threaded_expanded/collapsed functions had undefined * messages. The existing comment.tpl.php from the comment folder and Garland had an anchor tag with an id of "new" set. It's already printed out from theme_comment_view() so it was removed from the .tpl files.

CommentFileSizeAuthor
tplify_comment_1.patch10.96 KBdvessel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented

That id="new" needs to be put back -- that's how the node/2134#new got to the first new comment.

dvessel’s picture

dvessel CreditAttribution: dvessel commented

But it's already outputted through http://api.drupal.org/api/HEAD/function/theme_comment_view. And it checks for the first new comment. Just checking for new status the way the .tpl did would output it multiple times.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Fixed

dvessel is right (according to my testing). Committed to CVS HEAD. Thanks.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)