LDAP Authorization: exportables functionality broken [#1601270]

if ctools is enabled, ldap_authorization keeps adding new rows to ldap_authorization table and fails to save values correctly.

I commented out the ctools/exportable code for now and committed it. So now the configuration will save, but features and exportables isn't supported until this is fixed.

Comments

Comment #1

johnbarclay CreditAttribution: johnbarclay commented 27 May 2012 at 06:05

Title:

LDAP Authorization: exportables functionality broken, creates multiple records and fails to update configuration

» LDAP Authorization: exportables functionality broken

Creation of multiple records in ldap_authorization table is fixed and configuration update is working. Exportables still needs to be fixed.

Comment #2

jzornig CreditAttribution: jzornig commented 7 June 2012 at 00:35

I'm not familiar with the workings of exportables but currently in my features the ldap authorisation configuration from the feature doesn't appear in sites installing the feature. The feature seems to include the authorisation configuration in my_feature.ldap.authorization.inc
Where should I be looking to debug this?

Comment #3

johnbarclay CreditAttribution: johnbarclay commented 7 June 2012 at 03:22

in the authorization class itself in the load function. this is deliberately broken because it wasn't behaving correctly. the trick is to make the load from features/ctools work and the load from the ldap authorization table without breaking the update/insert functionality of the save. I'm not sure if both were ever working correctly so it might be better to look to another module that supports exportables rather than a past revision of ldap_authorization. Or even ldap_authentication may have exportables working it has the same class/table structure.

Comment #4

johnbarclay CreditAttribution: johnbarclay commented 10 June 2012 at 01:17

Status:

Active

» Fixed

Exportables functionality is fixed as well as the issue it broken. The commit (http://drupalcode.org/project/ldap.git/commitdiff/5bd42ee85dd2c08b419f30...) basically fixed the population of numericConsumerConfId property and renabled the exportables loading and saving code. It also fixed an unnecessary loop in the load process.

Most of the work went into getting the simpletests working and covering this issue. There is now a test for loading and saving with and without ctools enabled.