I know it's late to bring this up, since colorbox support is firmly embedded in this module. But I don't understand why we support colorbox instead of overlay module.

A lightbox (colorbox) is typically used for display of static content, like images or even video.

A modal frame (overlay) is for elements that have more interactivity; ie items that might have a form or links that you want to follow within the modal frame.

It seems to me that nodes more often fall into the second category than the first. Switching to support overlay would also eliminate all those pesky Ux problems around what happens when someone clicks the "edit" tab, or tries to comment, or follows a link etc.

Comments

tim.plunkett’s picture

The core overlay module is only used for admin pages, or optionally, content editing pages. It's never used to display content.

However, I'm not against this idea altogether.

ohthehugemanatee’s picture

StatusFileSize
new3.32 KB

It's pretty straightforward to use it for displaying content... http://drupal.org/project/overlay_paths makes it very easy to use it throughout your site.

Attached a patch that adds overlay support. I basically just copied what you had for colorbox to learn how it works. Probably more thought needs to go into the Views plugin interface, because I don't know what would happen if you select both Overlay and Colorbox. It would get interesting.

Anyway, this is enough as a start.

For people who have trouble getting their Admin theme to apply to nodes, see http://drupal.org/project/admin_theme .
There's also a core bug that can get in the way if you're using the overlay with path aliases; there's a D8 patch at #1240704: hook_admin_paths() doesn't work with path aliases that applies cleanly to D7.

tim.plunkett’s picture

Status:Active» Needs work
+++ b/sites/all/modules/fullcalendar/fullcalendar_options/js/overlay.fullcalendar.jsundefined
@@ -0,0 +1,28 @@
+          alert('penis');

...

ohthehugemanatee’s picture

StatusFileSize
new3.29 KB

dammit - just found that myself. lol - I was debugging it and forgot to take that out. Well, now the world knows that I have a puerile sense of humor.

Sorry about that - rerolled patch attached.

(boy is my face red!)

tim.plunkett’s picture

I guess its not too bad, my coworker uses "your mom".

muschpusch’s picture

Since we have ctools as a dependency why not using ctools overlay with some nice theming options? A lot of people disable the overlay module...

axel.rutz’s picture

milos.kroulik’s picture

Title:Why are we using colorbox instead of overlay?» Allow to display events in overlay instead of colorbox
Issue summary:View changes
Status:Needs work» Reviewed & tested by the community

It works fine for me, I just had to also enable paths in Overlay Paths module.

I think, that it can be commited.

jmary’s picture

That' s a good idea, because clicking on event is not always going on the node view page. On my project, it goes to the node edit.

jmary’s picture

StatusFileSize
new5.1 KB

The command patch -p1 <  1598712-fullcalendar-overlay.patch failed because of bad formatted patch.

I have recreated the patch with command :
diff -rupN fullcalendar.old fullcalendar.new > fullcalendar_overlayoption.patch
Now it applies properly.

jmary’s picture

Status:Reviewed & tested by the community» Needs review