Based on discussions in #1593058: Remove system.info's files[] entry, we are to move the tests in theme.test over to PSR-0.

CommentFileSizeAuthor
#7 1598614-theme-tests-psr0-7.patch60.95 KBaspilicious
#6 1598614-theme-tests-psr0-6.patch60.96 KBaspilicious
#4 1598614-withUnitTestSuffix.patch38.46 KBRobLoach
#3 1598614.patch38.44 KBRobLoach
#2 1598614.patch38.46 KBRobLoach
#1 convert_theme_test_to_psr0-1598614-1.patch59.28 KBAlbert Volkman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Albert Volkman’s picture

Albert Volkman CreditAttribution: Albert Volkman commented
Status: Active » Needs review
FileSize
convert_theme_test_to_psr0-1598614-1.patch59.28 KB

PSR-0'd.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Needs review » Reviewed & tested by the community
FileSize
1598614.patch38.46 KB

Same patch, but with the similarity index. Looks good! RTBC.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Reviewed & tested by the community » Needs review
FileSize
1598614.patch38.44 KB

Actually, let's remove "Unit" in HtmlTagUnitTest.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
FileSize
1598614-withUnitTestSuffix.patch38.46 KB

Actually, you had it right with UnitTest :-) . Sorry about that! Here's the patch from #2.

Status: Needs review » Needs work

The last submitted patch, 1598614-withUnitTestSuffix.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review
FileSize
1598614-theme-tests-psr0-6.patch60.96 KB

Should pass now

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
FileSize
1598614-theme-tests-psr0-7.patch60.95 KB

Small doc fix

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Needs review » Reviewed & tested by the community

Looks good!

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed/pushed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.