Based on discussions in #1593058: Remove system.info's files[] entry, we are to move the tests in password.test over to PSR-0.

CommentFileSizeAuthor
#6 convert_password_test_to_psr0-1598596-6.patch1.08 KBAlbert Volkman
#5 convert_password_test_to_psr0-1598596-5.patch1.08 KBAlbert Volkman
#3 convert_password_test_to_psr0-1598596-3.patch1.08 KBAlbert Volkman
#1 convert_password_test_to_psr0-1598596-1.patch1.06 KBAlbert Volkman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Albert Volkman’s picture

Albert Volkman CreditAttribution: Albert Volkman commented
FileSize
convert_password_test_to_psr0-1598596-1.patch1.06 KB

I'm not sure about the docblock for the class.

Albert Volkman’s picture

Albert Volkman CreditAttribution: Albert Volkman commented
Status: Active » Needs review
Albert Volkman’s picture

Albert Volkman CreditAttribution: Albert Volkman commented
FileSize
convert_password_test_to_psr0-1598596-3.patch1.08 KB

Updates per aspilicious in IRC.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Needs work 
+++ b/core/modules/system/lib/Drupal/system/Tests/Common/PasswordHashingTest.phpundefined
@@ -2,9 +2,11 @@
+ * Definition of Drupal\system\Tests\Password\HashingTest.

Tests\Common\PasswordHashingTest

+++ b/core/modules/system/lib/Drupal/system/Tests/Common/PasswordHashingTest.phpundefined
@@ -2,9 +2,11 @@
+namespace Drupal\system\Tests\Password;

Should be in the common namespace

==> Drupal\system\Tests\Common

22 days to next Drupal core point release.

Albert Volkman’s picture

Albert Volkman CreditAttribution: Albert Volkman commented
Status: Needs work » Needs review
FileSize
convert_password_test_to_psr0-1598596-5.patch1.08 KB

Bah.

Albert Volkman’s picture

Albert Volkman CreditAttribution: Albert Volkman commented
FileSize
convert_password_test_to_psr0-1598596-6.patch1.08 KB

One more time. Forgot to commit before doing my diff.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

done!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.