Convert menu.test to PSR-0

You need to remove the old test file ;)

+++ b/core/modules/system/lib/Drupal/system/Tests/Menu/MenuLinksUnitTest.phpundefined
@@ -0,0 +1,226 @@
+ * Definition of Drupal\system\Tests\Menu\MenuLinksUnitTest.

Remove the "Unit" part

+++ b/core/modules/system/lib/Drupal/system/Tests/Menu/MenuLinksUnitTest.phpundefined
@@ -0,0 +1,226 @@
+class MenuLinksUnitTest extends WebTestBase {

Same

+++ b/core/modules/system/lib/Drupal/system/Tests/Menu/MenuRouterTest.phpundefined
@@ -0,0 +1,552 @@
+ * Definition of Drupal\system\Tests\Menu\MenuLinksRouterTest.

Must be MenuRouterTest

+++ b/core/modules/system/lib/Drupal/system/Tests/Menu/MenuTreeDataTest.phpundefined
@@ -0,0 +1,65 @@
+ * Definition of Drupal\system\Tests\Menu\MenuTreeDataTest.

Here I would add "Unit" before Test like we did with other unit tests

+++ b/core/modules/system/lib/Drupal/system/Tests/Menu/MenuTreeDataTest.phpundefined
@@ -0,0 +1,65 @@
+class MenuTreeDataTest extends UnitTestBase {

Same, add Unit (and don't forget to rename the file)

22 days to next Drupal core point release.

Thanks for the review!

Didn't load MenuWebTest.

Srry one more thing.

+++ b/core/modules/system/lib/Drupal/system/Tests/Menu/MenuWebTest.phpundefined
@@ -0,0 +1,127 @@
+ * Definition of Drupal\system\Tests\Menu\MenuWebTest.

Can we make this MenuTest?

+++ b/core/modules/system/lib/Drupal/system/Tests/Menu/MenuWebTest.phpundefined
@@ -0,0 +1,127 @@
+class MenuWebTest extends WebTestBase {

Same

AND
class MenuBreadcrumbTest extends MenuWebTestCase
class MenuTrailTest extends MenuWebTestCase {

should extend MenuWebTestBase

You can fix all of this by applying this patch and just fix the few small problems that are left

22 days to next Drupal core point release.

Since the class MenuWebTestCase is now MenuTest, shouldn't they be extending MenuTest instead of MenuWebTestBase?

Base classes should end in Base so you should rename MenuTest to MenuTestBase

Re-roll.

Renamed functions removing preceding Menu.

+++ b/core/modules/system/lib/Drupal/system/Tests/Menu/BreadcrumbTest.phpundefined
@@ -0,0 +1,503 @@
+use Drupal\system\Tests\Menu\TestBase;

TestBase is located in the same namespace so you can remove this line

+++ b/core/modules/system/lib/Drupal/system/Tests/Menu/TrailTest.phpundefined
@@ -0,0 +1,211 @@
+use Drupal\system\Tests\Menu\TestBase;

Same

21 days to next Drupal core point release.

Patchin' away.

Thanks @Albert Volkman!

+++ b/core/modules/system/lib/Drupal/system/Tests/Menu/TrailTest.phpundefined
@@ -0,0 +1,209 @@
+class TrailTest extends MenuWebTest {

That one should probably extend MenuTestBase, no?

Nah, that'd make too much sense. ;-)

RouterTest.php needs a "use PDO;" on top of the file

Good times.

Good to go!

Committed and pushed to 8.x. Thanks!