Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Based on discussions in #1593058: Remove system.info's files[] entry, we are to move the tests in file.test over to PSR-0.
Comment | File | Size | Author |
---|---|---|---|
#16 | 1598574-file-tests-psr-0-16.patch | 246.64 KB | Niklas Fiekas |
#16 | 1598574-file-tests-psr-0-16-interdiff.txt | 666 bytes | Niklas Fiekas |
#14 | 1598574-file-tests-psr-0-14.patch | 246.65 KB | Niklas Fiekas |
#14 | 1598574-file-tests-psr-0-14-interdiff.txt | 655 bytes | Niklas Fiekas |
#10 | 1598574-file-tests-psr-0-10.patch | 248.98 KB | Niklas Fiekas |
Comments
Comment #1
BerdirWaiting for this one before I'll continue with #1468328: Move file entity info, managed file, and file usage functionality into File module. Once this is done, it will be *much* easier to move all classes that depend on the file entity to file.module.
Comment #2
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedDoing this now.
Comment #3
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedThis patch:
Comment #5
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedWhile the test was postponed and waiting for an 8.x retest, other PSR-0 patches made it in. Yay! Chasing info file changes.
Comment #7
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedNumber field tests failing looks pretty random to me. Going to test once more, before I am off to debugging this.
#5: 1598574-file-tests-psr-0-5.patch queued for re-testing.
Comment #8
BerdirAs discussed in IRC, this name is too short/generic. Same imho for HookTestBase.
I vote for FileTestBase.
Comment #9
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedYeah.
TestBase -> FileTestBase. HookTestBase -> FileHookTestBase.
Comment #10
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedMhh ... how could I forget 6 classes? Well spotted, @aspilicious. This one should be complete.
Comment #11
aspilicious CreditAttribution: aspilicious commentedYes! Great work!
Comment #13
aspilicious CreditAttribution: aspilicious commented$this->assertEqual($this->classname, file_stream_wrapper_get_class($this->scheme), t('Got correct class name for dummy scheme.'));
Is incorrect probably because the classname doesn't contain the namespace in it. Just hard code it for now.
Comment #14
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedThis one should be fine.
Comment #15
aspilicious CreditAttribution: aspilicious commentedWhy can't we use single backslashes, I believe that is our standard.
Comment #16
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedYeah ... no difference in single quotes strings unless at the very end, which is unlikely for class names. Only, that is the format the debug() statement I used to look up the class name serialized it.
Comment #17
aspilicious CreditAttribution: aspilicious commentedRdy!
Comment #18
RobLoach#16: 1598574-file-tests-psr-0-16.patch queued for re-testing.
Comment #19
webchickCommitted and pushed to 8.x! Thanks!