I believe this hook should be removed for 2 reasons:

  1. Activating a feature calls feature rebuild anyways
  2. When installing the features through an installation profile, this can cause unexpected results, because the "menu" feature would be enabled and therefore rebuilt before the other features. So for example if you have one feature for contents (with your UUID entities) and another one for menu links with menu links pointing to this content, rebuilding menu links BEFORE rebuilding the UUID entities will cause issues.

I will propose a patch to solve this issue.

CommentFileSizeAuthor
#3 uuid-menu_links-1.patch15.23 KBguillaumev
#1 1596990-remove_features_enable-1.patch534 bytesguillaumev
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

guillaumev’s picture

guillaumev CreditAttribution: guillaumev commented
Status: Active » Needs review
FileSize
1596990-remove_features_enable-1.patch534 bytes

The proposed patch solves the issue described

guillaumev’s picture

guillaumev CreditAttribution: guillaumev commented
Status: Needs review » Closed (won't fix)

This patch does not make sense anymore now that menu links support was dropped in favor of http://drupal.org/project/entity_menu_links

guillaumev’s picture

guillaumev CreditAttribution: guillaumev commented
FileSize
uuid-menu_links-1.patch15.23 KB

Adding this patch as for now I really need menu links support back in uuid...

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen commented

What do you mean with the following?

Activating a feature calls feature rebuild anyways

I interpret this as "When a feature module is enabled feature_rebuild() is called", but that is not true. When a module is enabled, features_modules_enabled() checks if it contains any features, and if this is the case it calls _features_restore('enabled') which invokes hook_features_enable_feature().

So hook_features_enable_feature() seems to be required to revert a feature on module enable.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Status: Closed (won't fix) » Needs work

@guillaumev Can entity_menu_links() & menu_links()?? I'm assuming you want this to be brought back in so that others can also use menu_links...

Patch no longer applies:

  $ git apply 1596990-remove_features_enable-1.patch 
  error: uuid.features.menu.inc: No such file or directory