Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aspilicious’s picture

Status: Active » Needs review
FileSize
2.56 KB

Will probably fail because of simpletest. We probably need to postpone this until the simpletest stuff is fixed.

Status: Needs review » Needs work

The last submitted patch, 1594628-profiles-tests-1.patch, failed testing.

jhodgdon’s picture

Component: documentation » other

This is not a documentation issue.

aspilicious’s picture

srry for that

RobLoach’s picture

Status: Needs work » Needs review
FileSize
2.21 KB

Hmm? Why is this failing?

Status: Needs review » Needs work

The last submitted patch, 1594628.patch, failed testing.

aspilicious’s picture

Because I renamed DrupalSystemListingCompatibleTestCase to DrupalSystemListingCompatibleTest and we use the classname in the simpletest tests.

Niklas Fiekas’s picture

Status: Needs work » Needs review
FileSize
1.58 KB
3.79 KB

Updated those references.

yurtboy’s picture

Status: Needs review » Reviewed & tested by the community

Patch applied cleanly

Checking patch core/modules/simpletest/simpletest.test...
Checking patch profiles/testing/modules/drupal_system_listing_compatible_test/drupal_system_listing_compatible_test.info...
Checking patch profiles/testing/modules/drupal_system_listing_compatible_test/drupal_system_listing_compatible_test.test => profiles/testing/modules/drupal_system_listing_compatible_test/lib/Drupal/drupal_system_listing_compatible_test/Tests/SystemListingCompatibleTest.php...
Applied patch core/modules/simpletest/simpletest.test cleanly.
Applied patch profiles/testing/modules/drupal_system_listing_compatible_test/drupal_system_listing_compatible_test.info cleanly.
Applied patch profiles/testing/modules/drupal_system_listing_compatible_test/drupal_system_listing_compatible_test.test => profiles/testing/modules/drupal_system_listing_compatible_test/lib/Drupal/drupal_system_listing_compatible_test/Tests/SystemListingCompatibleTest.php cleanly.

Is there some other tests I could run?

aspilicious’s picture

Yes this is rdy to go!

catch’s picture

Status: Reviewed & tested by the community » Fixed

Thanks. Committed/pushed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.