Patch coming soon, see also #1513210: Meta: Start converting module provided classes to PSR-0

Follow up issues

#1593450: Convert rdf tests to PSR-0

CommentFileSizeAuthor
#19 1594218.patch119.05 KBRobLoach
#16 1594218-taxonomy-tests-16.patch165.87 KBaspilicious
#14 1594218-taxonomy-tests-14.patch166.52 KBaspilicious
#12 1594218-taxonomy-tests-12.patch167.5 KBaspilicious
#10 1594218-taxonomy-tests-10.patch89.15 KBaspilicious
#4 1594218-taxonomy-tests-4.patch166.64 KBaspilicious
#2 1594218-2.patch165.23 KBRobLoach
#1 1594218-taxonomy-tests-1.patch165.24 KBaspilicious
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Active » Needs review
FileSize
1594218-taxonomy-tests-1.patch165.24 KB
RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
FileSize
1594218-2.patch165.23 KB

Casing of RSS and EFQ.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Looks good to me, can't rly rtbc...

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
FileSize
1594218-taxonomy-tests-4.patch166.64 KB

Reroll!

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Needs review » Reviewed & tested by the community
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Note: Committing this is waiting on
#1463656: Add a Drupal kernel; leverage HttpFoundation and HttpKernel
(and this will probably need a reroll once that is committed).

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Issue tags: +Avoid commit conflicts
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Issue tags: -Avoid commit conflicts

Um. Does *this* patch need the "Avoid commit conflicts" tag? This tag is supposed to be used for patches that are difficult to re-roll. This one is just a copy/paste, right? Pretty easy to re-create if something else makes a conflict... The issue noted in #6 already has that tag. Provisionally removing it from this issue.
See http://drupal.org/node/1207020#avoid-commit-conflicts

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented

Sounds good with me! :-)

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
FileSize
1594218-taxonomy-tests-10.patch89.15 KB

Reroll lets commit this now!

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Reviewed & tested by the community » Needs work

Hunk is missing will reroll soon

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review
FileSize
1594218-taxonomy-tests-12.patch167.5 KB
RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Needs review » Needs work 
+++ b/core/modules/system/config/system.site.ymlundefined
@@ -0,0 +1,8 @@
+name: Drupal
+mail: ''
+slogan: ''
+default_nodes_main: '10'
+page:
+    front: user
+    403: ''

This suppose to be in here?

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review
FileSize
1594218-taxonomy-tests-14.patch166.52 KB

Hopefully this one is better

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

#14: 1594218-taxonomy-tests-14.patch queued for re-testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
FileSize
1594218-taxonomy-tests-16.patch165.87 KB

Small doc changes

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Needs review » Reviewed & tested by the community

Nicely done. Added the RDF test to the issue summary as a follow up.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Reviewed & tested by the community » Needs work

Needs a one line reroll. See this diff: http://drupalcode.org/project/drupal.git/commitdiff/57ab8a546537dab6e4cb...

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Needs work » Needs review
FileSize
1594218.patch119.05 KB

So glad we're on git.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

back to rtbc

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Updated issue summary.