In #1270608: File-based configuration API we introduced the new configuration system. This included the settings for block cache. However in #918808: Standardize block cache as a drupal_render() #cache block caching was removed as a feature. This change happened after the initial patches and flew under the radar until now. So what needs to happen is that

- The core/modules/block/config/block.performance.xml file needs to be removed
- The core/modules/block/config directory also needs to go since it will now be empty

Additionally there is a test for block caching in testSystemBlocks() in system.test which should go (or perhaps be rewritten)

Files: 
CommentFileSizeAuthor
#6 drupal8.block-cache.6.patch3.41 KBsun
PASSED: [[SimpleTest]]: [MySQL] 36,954 pass(es). View
#5 1591710-5.patch1.13 KBheyrocker
PASSED: [[SimpleTest]]: [MySQL] 36,990 pass(es). View
#4 1591710-4.patch1.02 KBswentel
PASSED: [[SimpleTest]]: [MySQL] 36,584 pass(es). View

Comments

sun’s picture

Component: configuration system » block.module
Issue tags: +Configuration system
heyrocker’s picture

Component: block.module » configuration system

I was going to set this to block system but there is apparently no block system component which is a little surprising. Also tagging. This would be novice except I suspect getting the patch right to remove the file and directory is probably a bit tricky.

catch’s picture

Component: configuration system » block.module

What's wrong with the block module component (apart from the obvious :P).

swentel’s picture

Status: Active » Needs review
FileSize
1.02 KB
PASSED: [[SimpleTest]]: [MySQL] 36,584 pass(es). View
heyrocker’s picture

FileSize
1.13 KB
PASSED: [[SimpleTest]]: [MySQL] 36,990 pass(es). View

This looks good but it needed a reroll because all the tests moved around. New patch attached.

sun’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
3.41 KB
PASSED: [[SimpleTest]]: [MySQL] 36,954 pass(es). View
--- a/core/modules/system/lib/Drupal/system/Tests/System/BlockTest.php
+++ b/core/modules/system/lib/Drupal/system/Tests/System/BlockTest.php

WTF?

Let's delete that entire file.

The entire test case class is poor code that duplicates Block module's actual tests. (which is not to say that the Block tests are any better, but this is definitely dislocated code)

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.