Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
drupal_page_footer() has been ported to a terminate listener. It will be broken up further, but the function itself is no longer necessary. It should be removed outright.
Comment | File | Size | Author |
---|---|---|---|
#7 | 1591690-remove-drupal_page_footer-7.patch | 2.01 KB | bneil |
#3 | 1591690-remove-drupal_page_footer-3.patch | 1.47 KB | bneil |
Comments
Comment #1
bneil CreditAttribution: bneil commentedI'll work on this after the kernel patch lands #1463656: Add a Drupal kernel; leverage HttpFoundation and HttpKernel
Comment #2
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedYay! It's in :)
Comment #3
bneil CreditAttribution: bneil commentedThe attached patch:
Comment #4
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedThank you, bneil, this looks pretty good.
There's a few more references:
Can the comment in RequestCloseSubscriber be removed?
We probably need another issue to take care of ajax_footer(). The reference to drupal_page_footer() can now probably be removed.
The reference in the comment of bootstrap.inc should also be replaced with something.
Comment #5
Crell CreditAttribution: Crell commentedLet's leave the note in the RequestCloseSubscriber class for now. It's a todo because that class needs refactoring anyway.
ajax_footer()... I hadn't even remembered that function. :-) That should get ported to the new model as well. Can someone open an issue for that?
Comment #6
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedHere it is: #1618072: Remove ajax_footer(). That will take care of the two references in ajax.inc. So we shouldn't touch ajax.inc in this issue. Since we're also not touching the TODO, the only missing thing is to rewrite the comment in boostrap.inc.
Something like
Called when closing requests, we ...
?Comment #7
bneil CreditAttribution: bneil commentedThis patch incorporates the changes above with the following comment change per Niklas Fiekas:
// Called from drupal_page_footer, we write to permanent storage if there
Changed to:
// Called when closing requests, we write to permanent storage if there
Comment #8
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedThanks bneil, that looks good.
Comment #9
sunLooks good to me.
We likely need another follow-up for drupal_exit().
Comment #10
ltwinner CreditAttribution: ltwinner commentedoops
Comment #11
catchCommitted/pushed to 8.x, thanks!