Replace drupal_access_denied() with throw AccessDeniedHttpException

Patch done, need review ;-)

Add use SymfonyComponentHttpKernelExceptionAccessDeniedHttpException; /code>

Re-roll.

The are mentions of drupal_access_denied() scattered across the documentation, please update these too.

For example, in the documentation for drupal_deliver_page():

/**
 * Delivers a page callback result to the browser in the appropriate format.
 *
 * This function is most commonly called by menu_execute_active_handler(), but
 * can also be called by error conditions such as drupal_not_found(),
 * drupal_access_denied(), and drupal_site_offline().
 */

I'll do this, have done the same in #1587850: Replace drupal_not_found() with throw NotFoundHttpException. The patches in these two issues will give conflicts anyway since they are affecting the same lines of documentation.

Did the following updates to the patch in #8:

• Removed the drupal_access_denied() function itself.
• Updated documentation of drupal_deliver_page(), file_download() and search_box_form_submit().
• Replaced calls to drupal_acccess_denied() in aggregator_admin_refresh_feed(), comment_approve() and overlay_user_dismiss_message().
• Removed code that was never going to be executed after throwing the AccessDeniedHttpException in contact_site_form(), contact_personal_form(), menu_delete_menu_page(), menu_item_delete_page()

Awesome! And also: Yay! #1587850: Replace drupal_not_found() with throw NotFoundHttpException is in.
#12: 1591604-12-core-replace_drupal_access_denied.patch queued for re-testing.

You forgot to remove the drupal_access_denied() function

Did a grep, is rtbc if this come back green!

Rebased chrisdolby patch with remove drupal_access_denied(), edit file_download() comment and add AccessDeniedHttpException() in aggregator_admin_refresh_feed() function.

I hope that's good.

Oups you are so fast :)

They both are correct, but the patch command they use was different, thats why there is a size change. Btw you can't access the first patch anymore because they used the same name while crossposting, so the second one overwrites the first one.

No, one was core_replace and the other core-replace.

The first patch changes the file permissions which is wrong. The second one (#19) is RTBC.

Woow timplunkett, I didn't notice the subtle permission change in the git headers.
Thank you!

Great. Love the clean-ups. Committed to 8.x. Thanks!

This and several other issues look like they weren't actually committed/pushed. So, #19 is still RTBC.

Committed now: http://drupalcode.org/project/drupal.git/commit/002769e

For anyone who's looking for it, a change notification for this issue was started at http://drupal.org/node/1616360