Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aspilicious’s picture

Status: Active » Needs review
FileSize
20.65 KB

Status: Needs review » Needs work

The last submitted patch, 1591362-entity-tests-1.patch, failed testing.

aspilicious’s picture

Status: Needs work » Needs review
FileSize
23.82 KB

This one should pass :)

Tor Arne Thune’s picture

Status: Needs review » Needs work
+++ b/core/modules/entity/lib/Drupal/entity/Tests/EntityCrudHookTest.phpundefined
@@ -2,9 +2,11 @@
- * CRUD hook tests for the Entity CRUD API.
+ * Definition of Drupal\entity\Tests\EntityTranslationTest.

Wrong class name.

+++ b/core/modules/entity/lib/Drupal/entity/Tests/EntityTranslationTest.phpundefined
@@ -0,0 +1,119 @@
+ * Definition of Drupal\entity\Tests\EntityAPITest.

Same.

aspilicious’s picture

Status: Needs work » Needs review
FileSize
23.83 KB

Lets try this one

aspilicious’s picture

#5: 1591362-entity-tests-5.patch queued for re-testing.

RobLoach’s picture

#5: 1591362-entity-tests-5.patch queued for re-testing.

RobLoach’s picture

FileSize
23.83 KB

Acronyms are camel-cased.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Looks rdy to go!

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.