- started build from D7 openpublish profile build - then did any/all updates - D7 with all current modules and core -
I have been having a hard time in getting this module to work - the videos, regardless of source do not resize - there is little to no documentation on how to install and configure - it 'just works' are most comments on the few posts about how to enable & use the fitvids module -
- from http://groups.drupal.org/node/224939 I decided to uninstall and re-install - this time I put the jquery.fitvids.js in the libraries folders before installing the module -
- still no joy -
- then I noticed that ckeditor gets disabled on any node editing page - just plain text is available -
- disable fitvids module and ckeditor tools all reappear -
- when I install the module first and then put jquery.fitvids.js in the library folder ckeditor does not get disabled but fitvids does not work either -
any ideas?
Comment | File | Size | Author |
---|---|---|---|
#21 | FitVids-EmptySettings-1578130-17.patch | 0 bytes | danlinn |
#17 | FitVids-EmptySettings-1578130-17.patch | 2.75 KB | danlinn |
Comments
Comment #1
mkrakowiak CreditAttribution: mkrakowiak commentedThis module also disables any other wysiwyg editor that's installed through the wysiwyg module.
Comment #2
DerekAhmedzai CreditAttribution: DerekAhmedzai commentedCan you try the latest dev version? It should fix the issue.
Comment #3
mkrakowiak CreditAttribution: mkrakowiak commentedThanks, Derek. Unfortunately the issue persists. I tried the latest dev version, cleared both drupal and browser caches and no wysiwyg editor appears. I also changed the default jquery selector to something else than .region. I'm using the latest Omega 3 theme.
Comment #4
nikovitto CreditAttribution: nikovitto commentedSame here with stable or dev version, when fitvids is activate ckeditor still disable.
There is a JS error :
Is it possible to disable fitVids for admin page ?
Thx
Comment #5
nikovitto CreditAttribution: nikovitto commentedokay... my problem is solve, just put the correct jquery.fitvids.js and it's work... I make a stupid wget https://raw.github.com/davatron5000/FitVids.js
Comment #6
frost CreditAttribution: frost commentedi can confirm that using wysiwyg with ckeditor, enabling fitvids module kills ckeditor. this happens in both release and dev versions of fitvids.
[edit]
erm, actually it works if you download the correct file:
https://github.com/davatron5000/FitVids.js/blob/master/jquery.fitvids.js
Comment #7
DerekAhmedzai CreditAttribution: DerekAhmedzai commentedGreat, glad it's working
Comment #8
owen32 CreditAttribution: owen32 commentedActually, just tried this again and it still (regardless of above comments) disables ckeditor functionality, regardless of the https://github.com/davatron5000/FitVids.js/blob/master/jquery.fitvids.js source.
Comment #9
DerekAhmedzai CreditAttribution: DerekAhmedzai commentedThat's weird. I'll try installing a d7 openpublish build and see if it breaks for me, but in the meantime:
- are you using the ckeditor module or wysiwyg+ckeditor?
- is the fitvids js being inserted before jquery is called in the html?
- what theme(s) are you using?
Comment #10
owen32 CreditAttribution: owen32 commentedHello - this was attempted not on one server, but several and in for several different D7 web sites (includes an openpublish profile vs standard build D7 install version) - current it is with CKEditor 7.x-1.9 and FitVids version 7.x-1.8 but happened with older version (note my original post on the issue was May 2012) - this happens when FitVids is enabled/configured - it consistently disables ckeditor as seen when trying to edit any node -
I'm back to the CSS embed method:
/* RESPONSIVE VIDEO */
/* Modification 12052012 from code Written by Anders M. Andersen http://amobil.se/2011/11/responsive-embeds/ based on code from THIERRY KOBLENTZ http://www.alistapart.com/articles/creating-intrinsic-ratios-for-video/ */
==================================================
#VideoBlock {
width:100%;
}
.res-vid {
position: relative;
padding-bottom: 56.25%; /* 16/9 ratio */
padding-top: 30px; /* IE6 workaround*/
height: 0;
overflow: hidden;
}
.res-vid iframe,
.res-vid object,
.res-vid embed {
position: absolute;
top: 0;
left: 0;
width: 100%;
height: 100%;
}
Comment #11
mherchelI can confirm that this issue exists. I'm using the correct version of fitvids from https://github.com/davatron5000/FitVids.js/blob/master/jquery.fitvids.js.
I'm not sure why this is marked as closed, so I'm reopening it (if that's alright).
Thanks and let me know what I can do to help.
Comment #12
DerekAhmedzai CreditAttribution: DerekAhmedzai commentedJust set up a clean drupal 7.18 site - installed fitvids and wysiwyg/ckeditor, it worked for me...
Comment #13
juzzuu CreditAttribution: juzzuu commentedThe problem still exists.
Drupal 7.21
CKeditor 7.x-1.13 + 4.1.1
jQuery FitVids 1.0
Theme - Bartik and Omega 3
Jquery 1.5/1.7/1.8
In IE 9/10 no CKEditor, unless you disable the FitVids module. Is there a solution to this?
Comment #14
juzzuu CreditAttribution: juzzuu commentedThere is a solution, use WYMEditor at WYmeditor
It's visible in IE and Firefox, Chrome et.
I also tried tinymce , it was visible in IE but not in Firefox, Chrome etc????
Comment #15
chuntley CreditAttribution: chuntley commentedI'm getting the same problem with IE9, but haven't noticed any problems with Safari, Chrome, or Firefox. FWIW, I'm getting several javascript errors in IE as well. Maybe that's what's knocking out CKEditor?
Comment #16
goldlilys CreditAttribution: goldlilys commentedWas having problems with CKeditor with IMCE and no matter what solutions I tried the buttons were not showing up till I disabled FitVids and that solved the problem.
But not the solution I want since FitVids is needed for youtube videos to resize correctly. Hopefully this can be fixed soon. Thanks.
Comment #17
danlinn CreditAttribution: danlinn commentedThis patch checks for the settings before executing on them. Solved my problem for IMCE.
Comment #18
dhalbert CreditAttribution: dhalbert commentedWhat a timely patch! I just noticed the problem tonight with no buttons appearing in IMCE. Applied the patch (on 7.x-1.12) and all is well.
Comment #19
dhalbert CreditAttribution: dhalbert commentedUnfortunately, the patch fixed my IMCE problem, but fitvids stopped fitting. So I had to reverse the patch.
Comment #20
danlinn CreditAttribution: danlinn commentedYeah, my bad. New one coming...
Comment #21
danlinn CreditAttribution: danlinn commentedGive this one a whirl...
Comment #22
dhalbert CreditAttribution: dhalbert commentedOops, latest patch is 0 bytes long.
Comment #23
DerekAhmedzai CreditAttribution: DerekAhmedzai commentedThere's a new dev release, does that work?
Comment #24
deggertsen CreditAttribution: deggertsen commented@danlinn Your latest patch doesn't seem to have posted correctly. Could you repost it?
Comment #25
goldlilys CreditAttribution: goldlilys commentedYep #21 patch is 0 bytes which means it wasn't uploaded correctly. Please reupload when you can. Have to disable Fitvids for my sites temporarily for IMCE to be usable.
Thanks in advance when new patch is uploaded.
Comment #26
danwonac CreditAttribution: danwonac commentedI had a similar issue that was affecting image javascript crop.
I've got fitvids and image javascript crop / wysiwyg / ckeditor all working now with @danlinn's method of testing for settings.fitvids simply by wrapping the code in the test
if(!settings.fitvids == 'undefined') {
(and closing the if after the fitvids code). It looks to me like this is probably all patch 17 was supposed to do.
Comment #27
DerekAhmedzai CreditAttribution: DerekAhmedzai commentedThe current dev release checks for the existence of the settings variable in a similar way
If that works for you, I'll create a new official release.
Comment #28
danwonac CreditAttribution: danwonac commentedThanks for the follow up Derek, alas that doesn't work for me. The test is fine but the subsequent call to $('body').fitVids() throws TypeError: $(...).fitVids is not a function. The fitvids library is not loaded on the page that causes the problems (hence the error).
Temporarily I've removed the offending line and it is functioning for my use case again.
Comment #29
DerekAhmedzai CreditAttribution: DerekAhmedzai commentedI've created a new dev release which checks that fitvids exists first, and the whole lot is wrapped up in a try/catch statement.
Comment #30
danwonac CreditAttribution: danwonac commentedNew dev release fixes the issue I had.
Thank you for your time and an excellent module :)
Comment #31
DerekAhmedzai CreditAttribution: DerekAhmedzai commentedGreat, I'll create a new release.
Comment #32
deggertsen CreditAttribution: deggertsen commentedShould I wait for the new release or should I just install the dev version?
Comment #33
DerekAhmedzai CreditAttribution: DerekAhmedzai commentedMay as well just install the dev version for now - the new release isn't showing up for some reason.
Comment #34
smallcoder CreditAttribution: smallcoder commentedNice one Derek - the Dev version works a treat - solves the problem like a dream (after a minor nightmare!!!)
Comment #35
Jon Betts CreditAttribution: Jon Betts commentedAgreed! Works like a charm, thank you!!
Comment #36
deggertsen CreditAttribution: deggertsen commentedYes, it's fixed with the dev version!
Comment #37
DerekAhmedzai CreditAttribution: DerekAhmedzai commentedGreat, thanks for testing it. Have finally got a new release out!