- started build from D7 openpublish profile build - then did any/all updates - D7 with all current modules and core -

I have been having a hard time in getting this module to work - the videos, regardless of source do not resize - there is little to no documentation on how to install and configure - it 'just works' are most comments on the few posts about how to enable & use the fitvids module -

- from http://groups.drupal.org/node/224939 I decided to uninstall and re-install - this time I put the jquery.fitvids.js in the libraries folders before installing the module -

- still no joy -

- then I noticed that ckeditor gets disabled on any node editing page - just plain text is available -

- disable fitvids module and ckeditor tools all reappear -

- when I install the module first and then put jquery.fitvids.js in the library folder ckeditor does not get disabled but fitvids does not work either -

any ideas?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mkrakowiak’s picture

This module also disables any other wysiwyg editor that's installed through the wysiwyg module.

DerekAhmedzai’s picture

Can you try the latest dev version? It should fix the issue.

mkrakowiak’s picture

Thanks, Derek. Unfortunately the issue persists. I tried the latest dev version, cleared both drupal and browser caches and no wysiwyg editor appears. I also changed the default jquery selector to something else than .region. I'm using the latest Omega 3 theme.

nikovitto’s picture

Same here with stable or dev version, when fitvids is activate ckeditor still disable.

There is a JS error :

TypeError: $(".region", context).fitVids is not a function
$(".region", context).fitVids();

Is it possible to disable fitVids for admin page ?

Thx

nikovitto’s picture

okay... my problem is solve, just put the correct jquery.fitvids.js and it's work... I make a stupid wget https://raw.github.com/davatron5000/FitVids.js

frost’s picture

i can confirm that using wysiwyg with ckeditor, enabling fitvids module kills ckeditor. this happens in both release and dev versions of fitvids.

[edit]
erm, actually it works if you download the correct file:
https://github.com/davatron5000/FitVids.js/blob/master/jquery.fitvids.js

DerekAhmedzai’s picture

Status: Active » Closed (fixed)

Great, glad it's working

owen32’s picture

Actually, just tried this again and it still (regardless of above comments) disables ckeditor functionality, regardless of the https://github.com/davatron5000/FitVids.js/blob/master/jquery.fitvids.js source.

DerekAhmedzai’s picture

That's weird. I'll try installing a d7 openpublish build and see if it breaks for me, but in the meantime:

- are you using the ckeditor module or wysiwyg+ckeditor?
- is the fitvids js being inserted before jquery is called in the html?
- what theme(s) are you using?

owen32’s picture

Hello - this was attempted not on one server, but several and in for several different D7 web sites (includes an openpublish profile vs standard build D7 install version) - current it is with CKEditor 7.x-1.9 and FitVids version 7.x-1.8 but happened with older version (note my original post on the issue was May 2012) - this happens when FitVids is enabled/configured - it consistently disables ckeditor as seen when trying to edit any node -

I'm back to the CSS embed method:

/* RESPONSIVE VIDEO */
/* Modification 12052012 from code Written by Anders M. Andersen http://amobil.se/2011/11/responsive-embeds/ based on code from THIERRY KOBLENTZ http://www.alistapart.com/articles/creating-intrinsic-ratios-for-video/ */
==================================================

#VideoBlock {
width:100%;
}
.res-vid {
position: relative;
padding-bottom: 56.25%; /* 16/9 ratio */
padding-top: 30px; /* IE6 workaround*/
height: 0;
overflow: hidden;
}

.res-vid iframe,
.res-vid object,
.res-vid embed {
position: absolute;
top: 0;
left: 0;
width: 100%;
height: 100%;
}

mherchel’s picture

Status: Closed (fixed) » Active

I can confirm that this issue exists. I'm using the correct version of fitvids from https://github.com/davatron5000/FitVids.js/blob/master/jquery.fitvids.js.

I'm not sure why this is marked as closed, so I'm reopening it (if that's alright).

Thanks and let me know what I can do to help.

DerekAhmedzai’s picture

Just set up a clean drupal 7.18 site - installed fitvids and wysiwyg/ckeditor, it worked for me...

  • what theme(s) are you using? does it work if you use bartik and seven?
  • is the fitvids script ok? some people have used wget to get it and ended up with an HTML document, not the javascript
  • what version of jquery do you have installed?
  • is the video on the same page as the ckeditor editor?
  • what javascript errors are you getting (check the console)?
juzzuu’s picture

Version: 7.x-1.6 » 7.x-1.9

The problem still exists.
Drupal 7.21
CKeditor 7.x-1.13 + 4.1.1
jQuery FitVids 1.0
Theme - Bartik and Omega 3
Jquery 1.5/1.7/1.8

In IE 9/10 no CKEditor, unless you disable the FitVids module. Is there a solution to this?

juzzuu’s picture

There is a solution, use WYMEditor at WYmeditor
It's visible in IE and Firefox, Chrome et.

I also tried tinymce , it was visible in IE but not in Firefox, Chrome etc????

chuntley’s picture

I'm getting the same problem with IE9, but haven't noticed any problems with Safari, Chrome, or Firefox. FWIW, I'm getting several javascript errors in IE as well. Maybe that's what's knocking out CKEditor?

goldlilys’s picture

Was having problems with CKeditor with IMCE and no matter what solutions I tried the buttons were not showing up till I disabled FitVids and that solved the problem.

But not the solution I want since FitVids is needed for youtube videos to resize correctly. Hopefully this can be fixed soon. Thanks.

danlinn’s picture

Status: Active » Needs review
FileSize
2.75 KB

This patch checks for the settings before executing on them. Solved my problem for IMCE.

dhalbert’s picture

Status: Needs review » Reviewed & tested by the community

What a timely patch! I just noticed the problem tonight with no buttons appearing in IMCE. Applied the patch (on 7.x-1.12) and all is well.

dhalbert’s picture

Status: Reviewed & tested by the community » Needs work

Unfortunately, the patch fixed my IMCE problem, but fitvids stopped fitting. So I had to reverse the patch.

danlinn’s picture

Yeah, my bad. New one coming...

danlinn’s picture

Status: Needs work » Needs review
FileSize
0 bytes

Give this one a whirl...

dhalbert’s picture

Oops, latest patch is 0 bytes long.

DerekAhmedzai’s picture

There's a new dev release, does that work?

deggertsen’s picture

@danlinn Your latest patch doesn't seem to have posted correctly. Could you repost it?

goldlilys’s picture

Yep #21 patch is 0 bytes which means it wasn't uploaded correctly. Please reupload when you can. Have to disable Fitvids for my sites temporarily for IMCE to be usable.

Thanks in advance when new patch is uploaded.

danwonac’s picture

I had a similar issue that was affecting image javascript crop.

I've got fitvids and image javascript crop / wysiwyg / ckeditor all working now with @danlinn's method of testing for settings.fitvids simply by wrapping the code in the test

if(!settings.fitvids == 'undefined') {

(and closing the if after the fitvids code). It looks to me like this is probably all patch 17 was supposed to do.

DerekAhmedzai’s picture

The current dev release checks for the existence of the settings variable in a similar way

if (typeof settings.fitvids === 'undefined') {

If that works for you, I'll create a new official release.

danwonac’s picture

Thanks for the follow up Derek, alas that doesn't work for me. The test is fine but the subsequent call to $('body').fitVids() throws TypeError: $(...).fitVids is not a function. The fitvids library is not loaded on the page that causes the problems (hence the error).

Temporarily I've removed the offending line and it is functioning for my use case again.

DerekAhmedzai’s picture

I've created a new dev release which checks that fitvids exists first, and the whole lot is wrapped up in a try/catch statement.

danwonac’s picture

New dev release fixes the issue I had.

Thank you for your time and an excellent module :)

DerekAhmedzai’s picture

Great, I'll create a new release.

deggertsen’s picture

Should I wait for the new release or should I just install the dev version?

DerekAhmedzai’s picture

May as well just install the dev version for now - the new release isn't showing up for some reason.

smallcoder’s picture

Nice one Derek - the Dev version works a treat - solves the problem like a dream (after a minor nightmare!!!)

Jon Betts’s picture

Agreed! Works like a charm, thank you!!

deggertsen’s picture

Status: Needs review » Reviewed & tested by the community

Yes, it's fixed with the dev version!

DerekAhmedzai’s picture

Status: Reviewed & tested by the community » Fixed

Great, thanks for testing it. Have finally got a new release out!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.