Add check for author->mail in function _comment_notify_mailalert($comment)
Empty author->mail causes Error sending e-mail

CommentFileSizeAuthor
#3 1576878_no_anonymous_notification.patch1.37 KBgreggles
PASSED: [[SimpleTest]]: [MySQL] 46 pass(es). View
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

greggles’s picture

Makes sense, maybe we should look for an empty mail. That said...how did anonymous get subscribed to a notification?

dusov’s picture

admin/config/people/comment_notify
Check-box "Subscribe users to their node follow-up notification emails by default"
Thus, anonymous (who create node) get subscribed to a notification

greggles’s picture

Status: Active » Needs review
FileSize
1.37 KB
PASSED: [[SimpleTest]]: [MySQL] 46 pass(es). View

How about this, which adds some comments.

Status: Needs review » Needs work

The last submitted patch, 1576878_no_anonymous_notification.patch, failed testing.

greggles’s picture

Version: 7.x-1.0 » 7.x-1.x-dev
greggles’s picture

Status: Needs work » Needs review
greggles’s picture

Status: Needs review » Fixed

Now committed http://drupalcode.org/project/comment_notify.git/commit/b1a8cf3

Thanks for pointing this out, dusov.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.