Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up from #1536844-14: Port language/path handling to the kernel model. I don't know yet if this fixes test failures, but it does fix the bug reported there.
Comment | File | Size | Author |
---|---|---|---|
kernel-admin-theme.patch | 1.25 KB | effulgentsia |
Comments
Comment #1
aspilicious CreditAttribution: aspilicious commentedIt fixes all the problems I noticed.
- Shortcuts are back
- frontpage works
- admin theme is correct
Comment #2
effulgentsia CreditAttribution: effulgentsia commentedThis part fixes LocalePathFunctionalTest.
I don't know if this fixes a test, or if we're missing test coverage for 'xx/admin' returning the admin theme if xx is a language prefix. Similarly for aliases (e.g., if 'foo' is an alias for 'admin', then 'foo' should return the admin theme).
Comment #3
effulgentsia CreditAttribution: effulgentsia commentedComment #4
aspilicious CreditAttribution: aspilicious commentedAND it fixed the the last language fail
Comment #5
effulgentsia CreditAttribution: effulgentsia commentedSorry. Just noticed by looking at other issues in this project, that "bug report" is the correct category.
Lol. And sorry for the xposts :)
Comment #6
aspilicious CreditAttribution: aspilicious commentedBut yeah we are missing test coverage for the admin theme
Comment #7
Crell CreditAttribution: Crell commentedI am confused why the shortened ternary did not work here, but if this fixes it, fine. We can figure that out later. :-) Committed.
Comment #8
effulgentsia CreditAttribution: effulgentsia commentedCause if you have a path like 'xx' representing the home page in language xx, then after langcode stripping, system_path is empty string, which evaluates as FALSE. In this case, we want the next listener (home page resolver) getting back the empty string, not falling back to the request path.
Comment #9
Crell CreditAttribution: Crell commentedAh! OK, that makes sense. So I wasn't misunderstanding the ternary, just the edge case. :-) I wonder if we should document that then so that no one tries to tidy that up later.