I ran a site wide w3c check the other day and notice that filter/tips was not validating due to two duplicate IDs

This is the case in both Drupal 7 and Drupal 8

The IDs are the following:
filter-filter_url
…pe">No HTML tags allowed.</li><li id="filter-filter_url">Web page addresses an…

filter-filter_autop
…into links automatically.</li><li id="filter-filter_autop">Lines and paragraph…

They occur in the <ul class="tips"> list for each Text Format that is available.

An easy solution would be to change these to classes instead of id

CommentFileSizeAuthor
#1 filter-dup-ids-1564942-1.patch687 bytesKevin Morse
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Kevin Morse’s picture

Kevin Morse CreditAttribution: Kevin Morse commented
Issue summary: View changes

Forgot tags

Kevin Morse’s picture

Kevin Morse CreditAttribution: Kevin Morse commented
FileSize
filter-dup-ids-1564942-1.patch687 bytes

Here is a patch which changes the id to class and therefore prevents duplicate id's from being created for each text format present.

Kevin Morse’s picture

Kevin Morse CreditAttribution: Kevin Morse commented
Status: Active » Needs review

Woops forgot to change to needs review

Jody Lynn’s picture

Jody Lynn
she/her
Primary language English
CreditAttribution: Jody Lynn commented
Status: Needs review » Reviewed & tested by the community

Looks good. No core CSS is affected by this.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Needs review

Does not apply anymore. Needs a re-roll.

Dries’s picture

Dries CreditAttribution: Dries commented

#1: filter-dup-ids-1564942-1.patch queued for re-testing.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Fixed

Actually, I was wrong. Patch applied. Committed to 8.x. Thanks.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented

Seems like this would need a change notification for themers, no?
Don't know how we handle this, so not moving to "needs work" before getting some feedback.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

One more tag