Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I ran a site wide w3c check the other day and notice that filter/tips was not validating due to two duplicate IDs
This is the case in both Drupal 7 and Drupal 8
The IDs are the following:
filter-filter_url
…pe">No HTML tags allowed.</li><li id="filter-filter_url">Web page addresses an…
filter-filter_autop
…into links automatically.</li><li id="filter-filter_autop">Lines and paragraph…
They occur in the <ul class="tips">
list for each Text Format that is available.
An easy solution would be to change these to classes instead of id
Comment | File | Size | Author |
---|---|---|---|
#1 | filter-dup-ids-1564942-1.patch | 687 bytes | Kevin Morse |
Comments
Comment #0.0
Kevin Morse CreditAttribution: Kevin Morse commentedForgot
tags
Comment #1
Kevin Morse CreditAttribution: Kevin Morse commentedHere is a patch which changes the id to class and therefore prevents duplicate id's from being created for each text format present.
Comment #2
Kevin Morse CreditAttribution: Kevin Morse commentedWoops forgot to change to needs review
Comment #3
Jody LynnLooks good. No core CSS is affected by this.
Comment #4
Dries CreditAttribution: Dries commentedDoes not apply anymore. Needs a re-roll.
Comment #5
Dries CreditAttribution: Dries commented#1: filter-dup-ids-1564942-1.patch queued for re-testing.
Comment #6
Dries CreditAttribution: Dries commentedActually, I was wrong. Patch applied. Committed to 8.x. Thanks.
Comment #7
tstoecklerSeems like this would need a change notification for themers, no?
Don't know how we handle this, so not moving to "needs work" before getting some feedback.
Comment #8.0
(not verified) CreditAttribution: commentedOne more
tag