Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hello,
since the version 2012-May-04 the slideshow is broken on my system.
When I click on a picture only a picture is shown with JQuery.
Best regards
Frank
Comment | File | Size | Author |
---|---|---|---|
#7 | galleryformatter-7.x-1.x-dev.zip | 43.38 KB | kingdee40 |
#2 | picture1.png | 454.9 KB | fraweg |
#2 | picture2.png | 49.99 KB | fraweg |
Comments
Comment #1
Manuel Garcia CreditAttribution: Manuel Garcia commentedI'll need a bit more information than this, how many pictures do you have uploaded on there? Are any JS error messages showing up in the firebug js console? Also, what settings do you have for galleryformatter?
Comment #2
fraweg CreditAttribution: fraweg commentedHello, an thanks for your answer!
At the moment there are fife pictures. When I click an a picture it looks like picture1.But there is no slideshow. When I downgrade, everything works fine.
My Settings are on picture2.
Best regards
Frank
Comment #3
Manuel Garcia CreditAttribution: Manuel Garcia commentedLooks like you're setup is not picking up all the settings (you can now choose how you link to the full image). Have you tried clearing the cache after upgrading?
Comment #4
fraweg CreditAttribution: fraweg commentedHello,
thanks for your answer. Yes I have cleared the cache. This changes nothing. There must something chance in your code witch made this issue. With older Version everything woks fine.
Best regards
Frank
Comment #5
fraweg CreditAttribution: fraweg commentedDoes no one else have this issue?
Comment #6
kingdee40 CreditAttribution: kingdee40 commentedYes this is broken on mine as well, was driving me crazy for a while. The colorbox modal is never picked up in the latest dev version when trying to view an image, the image is displayed as a file. This still works with lightbox2 and shadowbox.
Comment #7
kingdee40 CreditAttribution: kingdee40 commentedThe 1.0 version doesn't work for me (image title issues) and the current dev doesn't work with colorbox. Good thing I had an old dev version laying around, it's attached if anyone else is having these problems.
Comment #8
johnvThe same happens here: The Colorbox was not showing after upgrding to the latest version of 8-may-2012.
I resaved the Formatter settings and switched from and to .
These settings work fine, and show the Colorbox (but i do not want 'on slide click'):
These settings do NOT show Colorbox (and this is what I like: a nice Hourglass):
Comment #9
johnvbetter title
Comment #10
Manuel Garcia CreditAttribution: Manuel Garcia commentedThank you @johnv for the very useful information. I can now duplicate and troubleshoot this bug. Working on it.
Comment #11
Manuel Garcia CreditAttribution: Manuel Garcia commentedOK, this was an easy fix once we knew in what situation it was failing...
Again, thanks johnv and everyone else for reporting.
Committed: http://drupalcode.org/project/galleryformatter.git/commit/2afed70
Comment #12
johnvOw, an invisible typo - hard to find. Glad it is solved.
Comment #13
johnvFor some reason this was committed, but didn't make it to the 7.x-1.x-dev download on the project page.
Comment #14
Manuel Garcia CreditAttribution: Manuel Garcia commentedthe change is in the tarball johnv... is it stil broken you mean?
Comment #15
johnvIt is not in the 'Development releases' of the project page:
Comment #16
fraweg CreditAttribution: fraweg commentedHello Manuel,
thanks for your work. Now it seems to work for me.
Best regards
Frank
Comment #17
Manuel Garcia CreditAttribution: Manuel Garcia commentedSo this is fixed on my installs...
@johnv let me know if you stil have trouble with the latest (make sure to update)
Comment #18
johnvHi Manuel,
the 7.x-1.x-dev .zip archive of 2012-Jul-20 is still broken (didn't test the .tar, but I suppose they are the same).
the same goes for 7.x-1.1 2012-Jul-13
Please do a download of the .zip file of 20-july. You will find this line in the .module file, still containing the space:
I didn't take a closer look, but I guess none of the latest commits are published on the project page. there is a problem with the git-tagging of your branches.
Comment #19
Manuel Garcia CreditAttribution: Manuel Garcia commentedIndeed that line is exactly like you pasted in the latest release, which is correct - that is the result of what the patch did, take a look:
http://drupalcode.org/project/galleryformatter.git/blobdiff/a5cc96902175...
I just retested both ways of linking to full, using colorbox and they both work.
Comment #20
johnvOK, now I am confused. I didn't realize that this patch switched the spaces, instead of removing it.
I removed both spaces, and it works fine for me, too.
I have no access to a system right now, but given the fact that you already have 277 1.0 releases out there, it MUST be solved. (277 happy users can't be wrong :-) )
Release Jul 8, 2012 Jul 1, 2012 Jun 24, 2012 Jun 17, 2012
7.x-1.x-dev 565 578 591 607
7.x-1.1 277 0 0 0
Comment #21
Manuel Garcia CreditAttribution: Manuel Garcia commentedA space is necessary to concatenate with the 'shownext' class:
If you need to remove the space in both cases here:
$link_attributes['class'] .= ($settings['linking_method'] == 'onclick_full') ? 'colorbox' : ' colorbox';
I'd like to know what settings you're using so that we can double check with those... I've tried combinations, they all seem to work as it is now...
Comment #22
johnvYou are right. This works flawlessly.