EntityMalformedException when deleting users, in og_get_user_roles()

I don't think this is an OG issue.

http://drupal.org/node/1565346

@madmatter23: If you change the owner back to the original user does that fix the error as well?

Also: Check your database node table for nodes with an empty type attribute.

I don't mean to be repetitive but there is a very similar issue posted for devel module (see issue #1902832 http://drupal.org/node/1902832#comment-7244672). The issue appeared on my site only when devel and og were working together. It is very frustrating as I am trying to build a large group site and could really use the devel generate with og. (Using ver 7.21)

adding detail to error message

I got a similar error (function og_get_user_roles) when worked with termstatus and OG, namely:

EntityMalformedException: Missing bundle property on entity of type taxonomy_term. in entity_extract_ids() (line 7734 of /var/www/site.loc/includes/common.inc).

As was described in the first comment: entity_load_single returns FALSE.

If core calls hook_query_TAG_alter during entity_load, then anything that calls entity_load (in this case OG) should expect that the query could have been altered.

So, we should add check in this case. Patch attached.

Same patch as #2729253: Missing bundle property on entity, if user has no access to the entity.

This resolved my issue. I deleted a node and there was a cache to deal with node access that seemed to providing the deleted node's gid to this function.

Maybe didn't update the moderation for the user yet, as in the cron or something didn't update og_membership table?
og_moderation_node_grants() called og_get_entity_groups('user', $account) which loaded the stale group from the og_membership table.

This seems to be related to #1673472: Deleting groups does not delete the group member users group audience references to the group

I found the same issue when i upgraded the organic groups module of version 7.x-2.10 causing the error 'EntityMalformedException: Missing bundle property on entity of type node. in entity_extract_ids()'

After debugging found in line 1830
if (is_numeric($entity)) {
$entity = entity_load_single($entity_type, $entity);
}
list(,, $bundle) = entity_extract_ids($entity_type, $entity);

Which actually worked with these
$wrapper = entity_metadata_wrapper($entity_type, $entity);
$bundle = $wrapper->getBundle();

Added the patch for it.
og-mising_bundle_property-1559766-12.patch

In my case, the issue was not from deleting users but rather from missing (or previously deleted) nodes, that were referenced by entity reference. What fixed it for me was checking if the entity was empty before calling entity_extract_ids().

function og_is_group($entity_type, $entity) {
  if (is_numeric($entity)) {
    $entity = entity_load_single($entity_type, $entity);
  }
  if (!empty($entity)) { // Check for missing entity
    list(,, $bundle) = entity_extract_ids($entity_type, $entity);
    if (!field_info_instance($entity_type, OG_GROUP_FIELD, $bundle)) {
      return variable_get("og_is_group__{$entity_type}__{$bundle}", FALSE);
    }
    $items = field_get_items($entity_type, $entity, OG_GROUP_FIELD);

    return !empty($items[0]['value']);
  }
}

@vsum
@signalScott
For the error in og_is_group(), see #2900273: Deleted groups causes EntityMalformedException in og_is_group()..

Changed title to better reflect differences with #2900273: Deleted groups causes EntityMalformedException in og_is_group()..

#7 resolved our issue as well. We are using the og_get_user_roles function in many custom modules and we were getting the EntityMalformedException error when handling orphaned content (similar to @signalScott).

I am not sure about #12 so I am hiding it for now.

#14 worked well for me. I was suspecting that the issue was caused by some deleted nodes.