Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The "Enable apps support" screen is a wall of text explaining various options to me. Yet, it has access to my environment variables, so presumably it could just tell me if I'm on Pantheon, or I have FTP/SSH extensions installed, or whatever, and give me little checkboxes/red Xs to help me along.
Comment | File | Size | Author |
---|---|---|---|
#9 | app-enable-verification-1555628-9.patch | 7 KB | nedjo |
#8 | apps-verify-failure.png | 82.87 KB | nedjo |
#8 | apps-verify-success.png | 34.64 KB | nedjo |
#8 | app-enable-verification-1555628-8.patch | 7 KB | nedjo |
#4 | app-enable-verification-1555628-4.patch | 4.87 KB | febbraro |
Comments
Comment #1
webchickOr, better still maybe, add checks like chmod 777 and the like to a panopoly_requirements() function so it doesn't let me continue installing without it.
Comment #2
populist CreditAttribution: populist commentedI think these are good changes to think about, but do believe they would be better done as part of the Apps module instead of something special for Panopoly. However, I do agree the current experience is less than ideal which is why I added the README to the installation process in the first place.
Comment #3
webchickThat makes sense. Moving queues.
Comment #4
febbraro CreditAttribution: febbraro commentedHere is a quick go at a documentation page that actually tests for these things as well. This is now including the verification page in the install profile tasks that get integrated with profile intall tasks.
Comment #5
e2thex CreditAttribution: e2thex commentedI Checked this out with the writeable dir and all went well, very nice addition.
Comment #6
nedjoYep, this is a big improvement.
In the case that all tests fail, should it still be possible to proceed? Maybe not, but then again particular install profiles form_alter in their own tests. Possibly add a 'value' form element that tracks success:
Then an install profile could alter this value before, in a #process callback, Apps tests the value and selectively disables the form (and gives a "try again" link).
Should be wrapped in t().
Comment #7
nedjoDidn't mean to change the status (forgot about dreditor).
Comment #8
nedjoMade a number of small tweaks:
$form['app_enabled']['#value']
, that can be set toTRUE
in aform_alter()
callback if a new enabled method is added.FALSE
, expand all fieldsets and set an error message.Screenshots attached for (a) success: only one method is enabled (FTP) and (b) failure: no methods are enabled.
Comment #9
nedjoFix typo in the previous patch.
Comment #10
nedjoIn some cases - when all selected apps are already installed - this proposed install task screen would be unneeded and therefore confusing. See #1714552: Install tasks for downloading and installing apps run even if all selected apps already installed.
Possibly it should come after apps have been selected, right before the potential prompt for FTP/SSH creds.
Comment #11
febbraro CreditAttribution: febbraro commented@nedjo RE: #10 you have a great point there. Let's open that up as another issue so it does not hold this one up. I have refined it a bit and committed the code for this. Fixed some wordings and added a "Retry verification" link to the warning message.
Thanks!
http://drupalcode.org/project/apps.git/commit/5c67cc4