Given that we recently moved the user language functionality to user module and the negotiation functionality to language module, the user language tests (and functionality) should now entirely work without locale module (with user + language). Since the code for assigning and storing the language is with user module, it looks logical to have the tests there too. As far as I see, these two are affected in locale.test:
class LocaleUserLanguageFunctionalTest extends DrupalWebTestCase
class LocaleUserCreationTest extends DrupalWebTestCase
These should not depend on locale anymore for their functionality AFAIS (only on language module) and should be in user.test.
Related: #1546752: Move negotiation tests to language module
Comment | File | Size | Author |
---|---|---|---|
#3 | user-tests-1552236-3.patch | 13.51 KB | duellj |
#1 | user-tests-1552236-1.patch | 13.51 KB | duellj |
Comments
Comment #1
duellj CreditAttribution: duellj commentedMoved LocaleUserLanguageFunctionalTest and LocaleUserCreationTest to user.test.
Comment #2
Gábor HojtsyYou also made them depend on language module which is great. They'd also need to be renamed (the classes) to conform with naming used in user.test. Otherwise looks good.
Comment #3
duellj CreditAttribution: duellj commentedUpdated class names to match classes in user.test.
Comment #4
DickJohnson CreditAttribution: DickJohnson commentedLooks good for me.
Comment #5
catchMakes sense. Committed/pushed to 8.x.
Comment #6
Gábor HojtsySuperb, thanks.
Comment #8
joewatkins CreditAttribution: joewatkins commentedThanks a lot for it
Comment #9
1ethylotest CreditAttribution: 1ethylotest commentedThis looks fine to me thanks :)