Given that we recently moved the user language functionality to user module and the negotiation functionality to language module, the user language tests (and functionality) should now entirely work without locale module (with user + language). Since the code for assigning and storing the language is with user module, it looks logical to have the tests there too. As far as I see, these two are affected in locale.test:

class LocaleUserLanguageFunctionalTest extends DrupalWebTestCase
class LocaleUserCreationTest extends DrupalWebTestCase

These should not depend on locale anymore for their functionality AFAIS (only on language module) and should be in user.test.

Related: #1546752: Move negotiation tests to language module

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

duellj’s picture

Status: Active » Needs review
FileSize
13.51 KB

Moved LocaleUserLanguageFunctionalTest and LocaleUserCreationTest to user.test.

Gábor Hojtsy’s picture

Status: Needs review » Needs work

You also made them depend on language module which is great. They'd also need to be renamed (the classes) to conform with naming used in user.test. Otherwise looks good.

duellj’s picture

Status: Needs work » Needs review
FileSize
13.51 KB

Updated class names to match classes in user.test.

DickJohnson’s picture

Status: Needs review » Reviewed & tested by the community

Looks good for me.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Makes sense. Committed/pushed to 8.x.

Gábor Hojtsy’s picture

Issue tags: -sprint

Superb, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

joewatkins’s picture

Thanks a lot for it

1ethylotest’s picture

This looks fine to me thanks :)