Just playing with Storm and coming across these issues. Trying to get them logged, will assist with patching if I can.

Notice: Undefined index: isactive in storm_attribute_list_submit() (line 176 of modules/storm/storm.admin.inc).
Recoverable fatal error: Argument 2 passed to db_query() must be an array, null given, called in /modules/storm/storm.admin.inc on line 176 and defined in db_query() (line 2313 of /includes/database/database.inc).

Files: 
CommentFileSizeAuthor
#4 storm-attributes_dbtng-2.patch1.24 KBjuliangb
PASSED: [[SimpleTest]]: [MySQL] 326 pass(es).
[ View ]

Comments

juliangb’s picture

Status:Active» Postponed (maintainer needs more info)

I'm struggling to reproduce this.

It might be that the bug has been fixed by other updates, or that I've just missed it.

Would you be able to post instructions for me to reproduce it please?

dbt102’s picture

Playing with Attributes at ...mysite/?q=storm/attributes ... to try and reproduce and got the following...

Recoverable fatal error: Argument 2 passed to db_query() must be an array, string given, called in mysite/sites/all/modules/storm/storm.admin.inc on line 176 and defined in db_query() (line 2313 of mysite/includes/database/database.inc).

To get it ... selected Attributes from main Storm dashboard and this displayed the attributes page well. I then selected Country "US" as "default" by clicking the radio button and then SAVE. This threw the error message above.

Then, tried to unclick the "Default" button, thinking I'd unset the default and it does not let me. Tried the edit icon, and that took me to the edit screen OK, but only the 'Active' box was selected. I unselected it and saved, this worked OK. But then when I selected the Active box and saved that using the save button at the bottom of the Attributes list ... it throws error like...

Recoverable fatal error: Argument 2 passed to db_query() must be an array, string given, called in mysite/sites/all/modules/storm/storm.admin.inc on line 176 and defined in db_query() (line 2313 of mysite/includes/database/database.inc).

juliangb’s picture

Status:Postponed (maintainer needs more info)» Active

Got it. I'd been editing attributes individually before.

juliangb’s picture

Status:Active» Needs review
StatusFileSize
new1.24 KB
PASSED: [[SimpleTest]]: [MySQL] 326 pass(es).
[ View ]

Patch to test.

Odd thing - seems like the undefined index notice is because when a checkbox isn't no value is returned by Drupal Forms API (rather than a FALSE or 0).

juliangb’s picture

Status:Needs review» Fixed

I've committed that patch.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.