Undefined index: rebuild in tablefield_rationalize_table [#1542446]

Been getting this error when ever I go to view a relation I set up that contains a tablefield:

Notice: Undefined index: rebuild in tablefield_rationalize_table() (line 595 of/home/dm7/sites/cscb.ca/modules/contrib/tablefield/tablefield.module).
Notice: Undefined index: rebuild in tablefield_rationalize_table() (line 596 of/home/dm7/sites/cscb.ca/modules/contrib/tablefield/tablefield.module).

It looks like the argument passed into the function is empty so I moved the code that tries to look up the row/column counts inside the check for !empty($tablefield).

Comment	File	Size	Author
#3	tablefield-1542446-03.patch	792 bytes	jamsilver
#3
#1	tablefield-undefined_index_error_in_table_rationalize-1542446-1.patch	900 bytes	ppc.coder
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

ppc.coder CreditAttribution: ppc.coder commented 22 April 2012 at 15:48

File	Size
tablefield-undefined_index_error_in_table_rationalize-1542446-1.patch	900 bytes

Here's the patch:

Comment #2

Les Lim

he/they

English

CreditAttribution: Les Lim commented 31 October 2012 at 19:33

Version:	7.x-2.0-beta6	» 7.x-2.x-dev
Status:	Needs review	» Reviewed & tested by the community

Simple and self-evident fix.

Comment #3

jamsilver CreditAttribution: jamsilver commented 29 May 2013 at 11:19

File	Size
tablefield-1542446-03.patch	792 bytes

Rolling a patch consistent with Drupal's patching conventions.

Comment #4

rjacobs CreditAttribution: rjacobs commented 11 June 2013 at 17:42

Just wanted to include another confirming review. Some testing and a code-level scan confirms this addresses the problem noted. This has been RTBC for quite a while now, is there anything standing in the way of a commit on this?