Don't check "create" access in OgSelectionHandler::buildEntityFieldQuery()

Is this for the case where a group member only has update group content permission, and when he goes to edit the group content, the group disappears from primary field since he doesn't have create group content permission?

Yeah, I encountered this when creating the test case, it's counter-intuitive but I guess whether it's a bug would depend on how you define the update group content permission (i.e. if it covers the case where user removes the content from this group).

Patch allows users with either "edit all content" or "edit own content" permission to a group to see it in the group list when editing group content.

Adding a test to patch 9.

Tests should still fail since entityreference isn't patched yet.

While the patch handles the use case of a group member needing to edit group content, there's still the use case of a site admin/editor needing to edit content without being a member. It seems to me that the buildEntityFieldQuery function could be modified so that in the case of users with "edit any {node_type}" at the global level (not group level), you load a larger set of groups that the user is allowed to assign the current content type to.

At the least, you could add the current node's group back into the list, with something like the following, inserted just under the call to og_get_groups_by_user on line 168:

    $node = $this->entity;
    $node_type = $this->instance['bundle'];
    if(user_access('edit any ' . $node_type)) {
      $user_groups[] = $node->og_group_ref[$node->language][0]['target_id'];
    }

Thoughts?

The problem with the "Other Groups" field method is that your primary Groups Audience field must be optional. If you have a site setup where your group content has a required+single Groups Audience field, using the Other Groups field will cause an error to be thrown.

This happens because, when you edit content in a group that you're not a member of, the required+single field will cause the first group in your list to get selected automatically. So when you submit the form, you're submitting both a value for the Groups Audience field and a value for the Other Groups field -- but OG can't push a group into the Groups Audience field because it only allows a single value.

Is there some other way to use the Other Group field that I'm overlooking? Otherwise, it seems like you really can't have a single+required Groups Audience field on group content at all.

I'm not very familiar with the Fields API in D7, but I can try. I see the place in OgSelectionHandler where I can add a settings field. But what's the best file & hook to use to alter the actual primary field so that it's not required?

Ok, further discussion about unrequiring the audience field for privileged users has moved here:
http://drupal.org/node/1580814