If I'm on the modules page I very often try to click on a modules name within the list of required modules to directly jump to the row with this module.
The attached patch creates anchors for each module (row) and links the module names in "Requires" and "Required by" to the specific row.

Unless #538904: D8UX: Redesign Modules Page gets in somehow this could be a small improvement.

CommentFileSizeAuthor
#13 1540780-interlink-modules-13.patch4.75 KBNiklas Fiekas
#8 1540780-interlink-modules-8.patch4.76 KBNiklas Fiekas
#8 1540780-interlink-modules-8-interdiff.txt1.97 KBNiklas Fiekas
#7 admin_modules__link_to_module_anchor-7.patch2.8 KBstBorchert
#5 admin_modules__link_to_module_anchor-5.patch2.94 KBstBorchert
admin_modules__link_to_module_anchor.patch2.82 KBstBorchert
admin_modules__link_to_module_anchor.jpg40.92 KBstBorchert
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented

Looks good to me, we saw this in the usability testing of the modules page too. Seems like a relatively simple patch too, another review and its RTBC from my POV. Also something we could roll back?

aschiwi’s picture

aschiwi CreditAttribution: aschiwi commented
Status: Needs review » Needs work

Nice patch! Works well when visiting admin/modules without overlay but the link doesn't jump when using overlay using Firefox (it works in Chrome).

aschiwi’s picture

aschiwi CreditAttribution: aschiwi commented
Status: Needs work » Needs review

That would be related to http://drupal.org/node/1129578 and probably can't be fixed within this patch here.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Needs work 
+++ b/core/modules/system/system.admin.incundefined
@@ -831,10 +831,10 @@ function system_modules($form, $form_state = array()) {
+          $extra['requires'][$requires] = t('!module (<span class="admin-enabled">enabled</span>)', array('!module' => l($requires_name, 'admin/modules', array('fragment' => 'module-' . $files[$requires]->name))));

Shouldn't it be something like t('@module_name ... At least that's what core uses on a lot of different places. This is the case for all 4 instances of the link.

stBorchert’s picture

stBorchert
he/him
Primary language German
CreditAttribution: stBorchert commented
Status: Needs work » Needs review
FileSize
admin_modules__link_to_module_anchor-5.patch2.94 KB

Changed !module to <a href="@url">@module</a> ...

Niklas Fiekas’s picture

Niklas Fiekas CreditAttribution: Niklas Fiekas commented
Issue tags: +Needs tests

Intresting patch. This looks like low-hanging fruit that improves usability a lot. Thank you, @stBorchert!

Since this adds a feature, we should probably have testcoverage for that. So a test should be added to core/modules/system/system.test, that checks a few anchors and a few links.

Notes from manual testing:

  • The patch applies, things work.
  • The checkbox as an anchor means that were jumping to the vertical center of a row, instead of to the stop. The sticky headers overlap.
  • In the Overlay: Clicking a link reloads the page, discarding changed checkbox states.
stBorchert’s picture

stBorchert
he/him
Primary language German
CreditAttribution: stBorchert commented
FileSize
admin_modules__link_to_module_anchor-7.patch2.8 KB

The sticky headers overlap.

This would be fixed (hopefully) with #1129578: Overlay doesn't respect internal anchor links.

Clicking a link reloads the page, discarding changed checkbox states.

Indeed. I've changed the patch to not generate a full url but the anchor only.

Niklas Fiekas’s picture

Niklas Fiekas CreditAttribution: Niklas Fiekas commented
Issue tags: -Needs tests
FileSize
1540780-interlink-modules-8-interdiff.txt1.97 KB
1540780-interlink-modules-8.patch4.76 KB

Awesome.

Adding tests.

Niklas Fiekas’s picture

Niklas Fiekas CreditAttribution: Niklas Fiekas commented
Status: Needs review » Needs work

Almost there. Unfortunately the module page is still reloaded when clicking links in the overlay. Can you reproduce this?

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Issue tags: +JavaScript

don't mind me, just tagging.

Niklas Fiekas’s picture

Niklas Fiekas CreditAttribution: Niklas Fiekas commented
Status: Needs work » Needs review
Issue tags: -JavaScript, -Usability, -#d8ux

#8: 1540780-interlink-modules-8.patch queued for re-testing.

We probably shouldn't hold this up on the reload issue. There's a major bug report for that, already: #1542472: Clicking on multiple anchor links while in overlay causes a page refresh potentially causing form data to be lost.

Status: Needs review » Needs work
Issue tags: +JavaScript, +Usability, +#d8ux

The last submitted patch, 1540780-interlink-modules-8.patch, failed testing.

Niklas Fiekas’s picture

Niklas Fiekas CreditAttribution: Niklas Fiekas commented
Status: Needs work » Needs review
FileSize
1540780-interlink-modules-13.patch4.75 KB

Patch no longer applied because of #1541676: Convert Simpletest base test classes to PSR-0.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs review » Needs work

Don't apply anymore.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ as a volunteer commented
Issue summary: View changes
Issue tags: -JavaScript

we don't have overlay anymore, no js necessary here.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.