Sometime in Drupal 5 or earlier, we moved the user table's access column to a separate table because it was updated every page request. In Drupal 6 and later, this only happens every 3 minutes per user, overwritable with a number of seconds in session_write_interval. I think we should not carry this hack forward to Drupal 7 since core has a different solution. It would be good to deploy this on Drupal 6, so we can verify it scales, and have one less thing changing in production on launch day.

Files: 

Comments

drumm’s picture

Issue tags:+Drupal.org D7
StatusFileSize
new4.74 KB
new594 bytes

It appears that Drupal.org's BZR commits to revert are 56 and 61. Diffs of these are attached.

Gerhard Killesreiter’s picture

Status:Active» Needs work

IIRC Narayan has previously said that the previous advantage we've had from doing this was gone now, so it is a good idea to revert.

The patches don't seem to be complete, there is some search related stuff in there that is unrelated and it is missing the profile module which was also patched.

webchick’s picture

We'll also need an upgrade path to move the value of the column and then drop the table.

Gábor Hojtsy’s picture

Are we planning to do this in the pressflow based vendor branch? Localize is also merged off of that and would be happy to get rid of this customization there too :)

drumm’s picture

Assigned:Unassigned» drumm
Issue tags:+porting

Tag. And I'll probably end up doing this myself.

drumm’s picture

Status:Needs work» Needs review
StatusFileSize
new781 bytes
new5.06 KB

Attached are patches to remove the core hacks, and a drupalorg update to move the data. Generated by diffing against bzr+ssh://util.drupal.org/bzr/vendor/pressflow/6.x-unbranded and cherry-picking chunks with users_access.

We'll keep the table for now so we can quickly roll back without DB changes.

Gábor Hojtsy – let's do this site-by-site.

drumm’s picture

Altering the users table will lock a lot of queries, so we need a downtime. I'd like to go for Thursday May 9th 5PM PDT (0:00 UTC). Here is a draft announcement: http://drupal.org/node/1989572

drumm’s picture

Narayan had no objections, so this is being deployed in about 24 hours.

drumm’s picture

Status:Needs review» Fixed

Deployed!

Automatically closed -- issue fixed for 2 weeks with no activity.