I would like to create a rule: 'when user updates account, if theme property has changed..."

This will also be useful property for Theme Rules.

CommentFileSizeAuthor
#4 entity-1540180-4.patch1.15 KBalexweber
#1 entity-1540180-1.patch1.03 KBalexweber
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexweber’s picture

alexweber CreditAttribution: alexweber commented
Status: Active » Needs review
FileSize
entity-1540180-1.patch1.03 KB

Patch attached.

mitchell’s picture

mitchell CreditAttribution: mitchell commented
Status: Needs review » Needs work

Patch applies cleanly and the property is available, but Rules doesn't behave as expected.

With this rule:

{ "rules_echo_theme" : {
    "LABEL" : "echo theme",
    "PLUGIN" : "reaction rule",
    "REQUIRES" : [ "rules" ],
    "ON" : [ "user_view" ],
    "DO" : [ { "drupal_message" : { "message" : [ "account:theme" ] } } ]
  }
}

I get an error: "Notice: Undefined index: custom translation language in RulesDataUI::selectionForm() (line 73 of sites/all/modules/rules/ui/ui.data.inc)", and the theme name doesn't appear in the system message. With [account:name], the message is displayed properly.

alexweber’s picture

alexweber CreditAttribution: alexweber commented

I overlooked this, Views integration might be broken too now that I think of it...
Reroll tonight when i get a chance!

alexweber’s picture

alexweber CreditAttribution: alexweber commented
Status: Needs work » Needs review
FileSize
entity-1540180-4.patch1.15 KB

Nothing was being displayed because in most cases the user's default theme is actually empty, and falls back to the site's default theme.

I've updated the patch to reflect that.

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented
Status: Needs review » Fixed

thanks, the default value for the theme_default (bartik) was missing. I've added + removed the unnecessary translatable key + committed it.

alexweber’s picture

alexweber CreditAttribution: alexweber commented

Awesome!

mitchell’s picture

mitchell CreditAttribution: mitchell commented

thx fago! thx alexweber!

While testing the patch, I realized... this solves #1344348: Port Theme Rules to D7 too!!
...Entity API + Rules... what an amazing combination!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.