Now that dependency injection has made it into core: #1497230: Use Dependency Injection to handle object definitions we should reduce the number of things we put into the $GLOBALS array, starting with things that touch the site's language .

On line 6284 of common.inc we have a $GLOBALS[$language_type]->langcode that should use the DI instead.

CommentFileSizeAuthor
#2 1539602_1_common_inc_di.patch495 bytescosmicdreams
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Component: language system » base system
Issue tags: +Dependency Injection (DI)
cosmicdreams’s picture

cosmicdreams CreditAttribution: cosmicdreams commented
FileSize
1539602_1_common_inc_di.patch495 bytes

small patch to fix a single line of code.

cosmicdreams’s picture

cosmicdreams CreditAttribution: cosmicdreams commented
Status: Active » Needs review
RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Yep. Committed/pushed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.