Files: 
CommentFileSizeAuthor
#17 dashboard-coder-fixes-2012-1533216-17.patch4.45 KBTravisCarden
PASSED: [[SimpleTest]]: [MySQL] 36,668 pass(es).
[ View ]
#14 dashboard-coding-standard-12.patch6.65 KBdinathecool
PASSED: [[SimpleTest]]: [MySQL] 35,262 pass(es).
[ View ]
#12 dashboard-coding-standard-12.patch6.63 KBdinathecool
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/dashboard/dashboard.module.
[ View ]
#6 dashbord-codingstandard-6.patch2.62 KBdinathecool
PASSED: [[SimpleTest]]: [MySQL] 35,428 pass(es).
[ View ]
#4 patch-1.patch3.59 KBj2r
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch patch-1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

j2r’s picture

Run Coder with minor on dashboard module and its giving 0 warnings.

NROTC_Webmaster’s picture

Did you also run it through drupalcs? If so we can go ahead and mark this closed.

j2r’s picture

I am not sure how to run drupalcs on D8. I will try and will update here.

j2r’s picture

StatusFileSize
new3.59 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch patch-1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
FILE: /var/www/html/d8/core/modules/dashboard/dashboard.module
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
682 | ERROR | String concat is not required here; use a single string instead
684 | ERROR | String concat is not required here; use a single string instead
--------------------------------------------------------------------------------

FILE: /var/www/html/d8/core/modules/dashboard/dashboard.test
--------------------------------------------------------------------------------
FOUND 3 ERROR(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
12 | ERROR | Missing function doc comment
20 | ERROR | Missing function doc comment
24 | ERROR | If the line declaring an array spans longer than 80 characters,
    |       | each element should be broken into its own line
--------------------------------------------------------------------------------

I have attached initial patch and above are the remaining error, will work on it and upload the patch again.

dinathecool’s picture

Assigned:Unassigned» dinathecool
dinathecool’s picture

Status:Needs work» Active
StatusFileSize
new2.62 KB
PASSED: [[SimpleTest]]: [MySQL] 35,428 pass(es).
[ View ]

after working out with this issue in .module file i am still getting the following errors

FILE: ...home/dina/www/drupal--8-sandbox/core/modules/dashboard/dashboard.module
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
682 | ERROR | String concat is not required here; use a single string instead
684 | ERROR | String concat is not required here; use a single string instead
--------------------------------------------------------------------------------

in

function theme_dashboard_disabled_block($variables) {
  extract($variables);
  $output = "";
  if (isset($block)) {
    $output .= '<div id="block-' . $block['module'] . '-' . $block['delta']
    . '" class="disabled-block block block-' . $block['module'] . '-' . $block['delta']
    . ' module-' . $block['module'] . ' delta-' . $block['delta'] . '">'
    . '<h2>' . (!empty($block['title']) && $block['title'] != '<none>' ? check_plain($block['title']) : check_plain($block['info'])) . '</h2>'
    . '<div class="content"></div>'
    . '</div>';
  }
  return $output;
}

i think if we remove the concat operator then it will affect the functionality
what can we do

i am attaching patch below

dinathecool’s picture

Status:Active» Needs review
dinathecool’s picture

Status:Needs review» Needs work
cosmicdreams’s picture

for #6, make it use a template instead.

NROTC_Webmaster’s picture

Status:Active» Needs work

I'm actually not getting the concat operator error.
Also, we are not adding param/return datatypes in this issue.

lotyrin’s picture

It wants '">' . '<h2>' to be '"><h2>' and '</h2>' . '<div class="content"></div>' . '</div>' to be '</h2><div class="content"></div></div>'' etc.

This wouldn't affect functionality.

Changing this to use a template seems beyond the scope of this issue.

dinathecool’s picture

Status:Active» Needs review
StatusFileSize
new6.63 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/dashboard/dashboard.module.
[ View ]

i solved the issue and dashboard module passed the coder review i am attching my patch below

can somebody review my patch

dinathecool’s picture

Status:Needs work» Active
dinathecool’s picture

Status:Needs review» Active
StatusFileSize
new6.65 KB
PASSED: [[SimpleTest]]: [MySQL] 35,262 pass(es).
[ View ]

sorry attached the old patch in 12 attching new patch below

dinathecool’s picture

Status:Active» Needs review
NROTC_Webmaster’s picture

Status:Needs review» Needs work

dinathecool,

You need to remove the datatypes from the patch.

TravisCarden’s picture

Status:Needs work» Needs review
StatusFileSize
new4.45 KB
PASSED: [[SimpleTest]]: [MySQL] 36,668 pass(es).
[ View ]

How about this?

dinathecool’s picture

Assigned:dinathecool» Unassigned
TravisCarden’s picture

Status:Needs review» Fixed

The dashboard module has been removed from core. http://drupal.org/node/1697190

lotyrin’s picture

Title:Make dashboard module pass Coder Review» Make module pass Coder Review
Project:Drupal core» Dashboard
Version:8.x-dev» 6.x-2.x-dev
Component:dashboard.module» Code
Status:Fixed» Needs work

Moving to the dashboard project, since there's a patch already that might be nice for them to have there.

Version is wrong but 8.x doesn't exist yet so...