format plural cuts of the value if value over thousand and comma thousand marker selected

Also getting this problem. It also seems that if the node views go over 1999 the problem goes away

Guys, after some debugging it seems the problem is in core or at least with what the views numeric handler is passing to core (format_plural)

At the top of format_plural is:

function format_plural($count, $singular, $plural, array $args = array(), array $options = array()) {
  $args['@count'] = $count;
  if ($count == 1) {
    return t($singular, $args, $options);
  }

if you print $count when you have a comma seperator itll return 1,001 this is ==1 but is not === 1 so either core has to change to check on type and value or view handler has to passs an actual number.

Problem is on line 125 of views_handler_field_numeric.inc.

I don't think there is a good way to solve this issue without rewriting the entire render function, or doing an API breaking hack that simply concatenates the value and the format plural string (without the value). I don't see any way of making this change that won't break people's views who may be using plural formatting.

The summary of the bug is that the separator configuration is incompatible with precision or plural formatting.

This also applies to Drupal 8, which is a core issue now.

On second thought, I think this is probably a bug in Drupal core with format_plural(). Especially if it supports 10,000, but not 1,001.

Came across the issue and I need it fixed or I need a patch which I can access for an installation profile.

Here's a quick fix that won't break any existing views.

This patch was sponsored by NDITech, the technical department of the National Democratic Insitute.

Sorry, I put a wrong patch.

Here's the correct patch.

#6 Patch is working fine with 7.x-3.13 but for 7.x-3.14 patch is not working. Changes would not be reflected without applying patch.

If there is an issue with the patch in #6 when applying to "7.x-3.x" branch, then the issue should be changed to "Needs work". The "Reviewed & tested by the community" status should be used when a patch is ready to be committed. It does not seem from your comment that the patch is ready to be committed.

If the patch applies to 7.x-3.x and fixes the issue, maybe change the issue to RTBC. If not, then the issue should be in Needs Work.

PFA patch

The 2 year old patch in #11 to views_handler_field_numeric.inc does not apply to the latest views 7.x-3.x-dev and if still relevant needs to be rerolled.

format_plural_cuts_of-1515834-11.patch:16: trailing whitespace.
	
Checking patch handlers/views_handler_field_numeric.inc...
error: while searching for:

  function render($values) {
    $value = $this->get_value($values);

    // Hiding should happen before rounding or adding prefix/suffix.
    if ($this->options['hide_empty'] && empty($value) && ($value !== 0 || $this->options['empty_zero'])) {
      return '';
    }

    if (!empty($this->options['set_precision'])) {
      $value = number_format($value, $this->options['precision'], $this->options['decimal'], $this->options['separator']);
    }

error: patch failed: handlers/views_handler_field_numeric.inc:107
error: handlers/views_handler_field_numeric.inc: patch does not apply

@Chris2 What you're doing here may actually cause harm. In the above case you've indiscrimenately hidden all files from #11, making #6 the most recent patch at the top of the issue.

Please go through all issues that you've updated over the past several days (weeks?) and unhide any files that were hidden by your script.

Understood, I was doing this manually but I can go back and edit.

Understood, I was doing this manually but I can go back and edit.

Thank you. If you need to review your comments, I've created a small online helper.

Patch rerolled.

Wrong patch attached previously, this is right (from #6).