The links in the details block are important interface elements that are sometimes required outside of the block. The functionality can be duplicated, but if it is it will no longer be alterable via hooks.

Proposed resolution

break out the link generation into a function that returns an array that is ready for the links theme function.

Remaining tasks

Review by community. Patch is ready.

User interface changes


API changes

Adds a function that can be used outside of OG that generates the links in the details block.

#3 og.1512938-3.og_details_api.patch1.53 KBGrayside
PASSED: [[SimpleTest]]: [MySQL] 269 pass(es). View
#2 OG-details-block-links.patch1.25 KBmirzu
PASSED: [[SimpleTest]]: [MySQL] 269 pass(es). View
OG-details-block-links.patch2.62 KBmirzu
PASSED: [[SimpleTest]]: [MySQL] 269 pass(es). View


Grayside’s picture

Status: Active » Needs work

Hi mirzu, fantastic! I am very much in favor of this.

However, it appears that the patch was rolled against an older version of OG, as a result it is mostly regressions of issues fixed in the last couple months. Could you reroll the patch against the current dev version?

mirzu’s picture

Status: Needs work » Needs review
1.25 KB
PASSED: [[SimpleTest]]: [MySQL] 269 pass(es). View

Hi Grayside,

Sorry didn't even look at the patch. attached is a new version that only breaks out the links without breaking everything.

Grayside’s picture

Status: Needs review » Reviewed & tested by the community
1.53 KB
PASSED: [[SimpleTest]]: [MySQL] 269 pass(es). View

Hey mirzu,

Jumped the gun a bit, wanted the API function to be a bit more versatile just on principle. Please cross-check the attached patch.

mirzu’s picture

Looks good to me. I like passing in the node just in case someone wants to so something really sneaky. :)

Grayside’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.