I created a subtheme using Footheme, but I'm noticing a layout problem on a handful of pages. After looking at the source, I noticed that the theme's *.responsive.layout.css is loading with a different weight on certain pages. The problematic pages, that file is loading above at.layout.css, which provides the default layouts -- and that ruins everything.

Any ideas?

Thanks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mstef’s picture

Project: Footheme » AdaptiveTheme
Version: 7.x-2.0 » 7.x-2.2
Component: Code » AT Core

Moving to AdaptiveTheme queue.

I found the problem..

It's on line 89 of template.process.inc. We need a 'weight' added to the array of something like 99, to ensure it's loaded at the end.

Patch coming

mstef’s picture

Patch (sorry if this is a dupe)

Jeff Burnz’s picture

Yeah, its a major problem in part caused by Drupal and in part caused by Views blocks caching which recalculates the weights, Tim Plunkett posted a patch for core that fixes it, but you are right, the only way around this in contrib is set a big weight.

mstef’s picture

Component: AT Core » CSS/HTML

Despite using this patch, I'm now getting this issue in IE when CSS aggregation is turned on -- same problem. I'm really not sure why it would only be happening in IE, though, I'm far from surprised..

Jeff Burnz’s picture

Got a link to you site mikestefff?

mstef’s picture

Status: Active » Needs review

Nah, it's not up right now -- sorry. I came across #1454550: sidebar width is on IE8 different with agregated css-files, so we'll keep the IE/aggregation discussion on there, and reserve this issue for what I originally opened it up for.

Marking as needs review, for my patch.

Jeff Burnz’s picture

Issue tags: +CSS Weight

tagging all issues like this to do with CSS weight

Jeff Burnz’s picture

Status: Needs review » Fixed

Will commit shortly, the patch has been ported, I bumped the weight right up, just to be utterly sure this always comes last.

Jeff Burnz’s picture

Committed with attribution, thank-you for the contribution mikestefff, much appreciate, only sorry its taken me this long to find some time to work on 7.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mstef’s picture

No problem. Thanks for the update.