Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I created a subtheme using Footheme, but I'm noticing a layout problem on a handful of pages. After looking at the source, I noticed that the theme's *.responsive.layout.css is loading with a different weight on certain pages. The problematic pages, that file is loading above at.layout.css, which provides the default layouts -- and that ruins everything.
Any ideas?
Thanks
Comment | File | Size | Author |
---|---|---|---|
#2 | adaptivetheme-missing-weight-responsive-css-1512736.patch | 408 bytes | mstef |
Comments
Comment #1
mstef CreditAttribution: mstef commentedMoving to AdaptiveTheme queue.
I found the problem..
It's on line 89 of template.process.inc. We need a 'weight' added to the array of something like 99, to ensure it's loaded at the end.
Patch coming
Comment #2
mstef CreditAttribution: mstef commentedPatch (sorry if this is a dupe)
Comment #3
Jeff Burnz CreditAttribution: Jeff Burnz commentedYeah, its a major problem in part caused by Drupal and in part caused by Views blocks caching which recalculates the weights, Tim Plunkett posted a patch for core that fixes it, but you are right, the only way around this in contrib is set a big weight.
Comment #4
mstef CreditAttribution: mstef commentedDespite using this patch, I'm now getting this issue in IE when CSS aggregation is turned on -- same problem. I'm really not sure why it would only be happening in IE, though, I'm far from surprised..
Comment #5
Jeff Burnz CreditAttribution: Jeff Burnz commentedGot a link to you site mikestefff?
Comment #6
mstef CreditAttribution: mstef commentedNah, it's not up right now -- sorry. I came across #1454550: sidebar width is on IE8 different with agregated css-files, so we'll keep the IE/aggregation discussion on there, and reserve this issue for what I originally opened it up for.
Marking as needs review, for my patch.
Comment #7
Jeff Burnz CreditAttribution: Jeff Burnz commentedtagging all issues like this to do with CSS weight
Comment #8
Jeff Burnz CreditAttribution: Jeff Burnz commentedWill commit shortly, the patch has been ported, I bumped the weight right up, just to be utterly sure this always comes last.
Comment #9
Jeff Burnz CreditAttribution: Jeff Burnz commentedCommitted with attribution, thank-you for the contribution mikestefff, much appreciate, only sorry its taken me this long to find some time to work on 7.x-2.x.
Comment #11
mstef CreditAttribution: mstef commentedNo problem. Thanks for the update.