Saving files does not always work because the code does not tale into consideration that $_SERVER['DOCUMENT_ROOT'] can be different on different systems and because it does not trim cache data from CSS files URL to be saved.
Patch below fixes both issues.

CommentFileSizeAuthor
live_css-saving_files_does_not_always work.patch5.14 KBhles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

guybedford’s picture

guybedford CreditAttribution: guybedford commented
Status: Needs review » Closed (fixed)

Thanks, included in the latest release.

guybedford’s picture

guybedford CreditAttribution: guybedford commented
Status: Closed (fixed) » Needs review

I've put this into the development branch, along with some other fixes.

So I don't mess up on the release again, is there any chance you could test this as well before I push a 2.x-2.3 version?

Would be much appreciated.

hles’s picture

hles CreditAttribution: hles commented
Status: Needs review » Fixed

Well, it saves the files on my configuration. But I think its premature to release a 2.3 version because this needs more tests and there are a few other issues to fix before; I will add them in the issue queue.

Btw, you now have _live_css_sanitize_css_url($url) and _css_live_sanitize_css_url($url) in your dev code. Don't forget to remove _css_live_sanitize_css_url and call _live_css_sanitize_css_url instead.

guybedford’s picture

guybedford CreditAttribution: guybedford commented
Status: Fixed » Closed (fixed)

Thanks. I'm going to push this release out soon as there is a bug in the current one. A lesson well learned for not rushing this process in future.