In config_install_default_config I think we can replace three lines that extract config name from filename with a single line using http://us3.php.net/basename

Files: 
CommentFileSizeAuthor
#4 cmi_base_name.patch674 bytesmarcingy
PASSED: [[SimpleTest]]: [MySQL] 35,910 pass(es). View
cmi_install_config_basename.patch774 bytesRok Žlender
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed. View

Comments

Status: Needs review » Needs work
Issue tags: -Configuration system

The last submitted patch, cmi_install_config_basename.patch, failed testing.

Rok Žlender’s picture

Status: Needs work » Needs review

cmi_install_config_basename.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Configuration system

The last submitted patch, cmi_install_config_basename.patch, failed testing.

marcingy’s picture

Status: Needs work » Needs review
FileSize
674 bytes
PASSED: [[SimpleTest]]: [MySQL] 35,910 pass(es). View

We need a little bit more but this still tidies up the code a little bit.

ksenzee’s picture

Does anyone know why the first patch didn't work? I would think it should have.

Rok Žlender’s picture

Yes. I removed a variable that is needed later on in that function.

sun’s picture

Status: Needs review » Closed (duplicate)