With it possible to send HTML emails, it would be nice to not have to limit this to users who know HTML(we've got clients who are in this situation). The usual solution to this is to use Wysiwyg (http://drupal.org/project/wysiwyg). Would it be possible to provide for attaching Wysiwyg to the email body field?

CommentFileSizeAuthor
#9 views_send-add_wysiwyg-1507666-8.patch2.62 KBjasonmce
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Ben Coleman’s picture

Ben Coleman CreditAttribution: Ben Coleman commented
Title: Attach a Wysisyg editor to the mail body? » Attach a Wysiwyg editor to the mail body?
hansfn’s picture

hansfn CreditAttribution: hansfn commented
Title: Attach a Wysiwyg editor to the mail body? » Attach a Wysiwyg editor to the mail body textarea?
Assigned: Unassigned » hansfn

Sure, that's a good idea (and it's not hard). I'm very busy this week, but early next week I should be able to add this (if no one beats me to it).

hansfn’s picture

hansfn CreditAttribution: hansfn commented
Project: Views Send Drupal 7 Port » Views Send
Version: » 7.x-1.x-dev
jasonmce’s picture

jasonmce CreditAttribution: jasonmce commented

Unless someone has already started the wysiwyg integration, I can probably have a patch posted by mid-week.

hansfn’s picture

hansfn CreditAttribution: hansfn commented

Hi, Jason. I started looking at it, but got blocked by other (paid) work. Your patch is very much appreciated.

Ben Coleman’s picture

Ben Coleman CreditAttribution: Ben Coleman commented

Jason, how is the wysiwyg patch coming?

jasonmce’s picture

jasonmce CreditAttribution: jasonmce commented

I'm testing it now, hopefully have it posted tonight/tomorrow. Got distracted by (paid) work and wedding anniversary celebration (both important to my continued happiness).

jasonmce’s picture

jasonmce CreditAttribution: jasonmce commented
Status: Active » Needs review
FileSize
views_send-add_wysiwyg-1507666-8.patch2.62 KB

This is my first attempt at a drupal patch, so lets see how close I got.

hansfn’s picture

hansfn CreditAttribution: hansfn commented

I have looked quickly at the patch and it looks good. I'll test it properly this weekend and make a commit that fixes this issue.

hansfn’s picture

hansfn CreditAttribution: hansfn commented
Status: Needs review » Fixed

Fixed in commit/39de6f7.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

benjarlett’s picture

benjarlett CreditAttribution: benjarlett commented
Issue summary: View changes

I've tried using the current dev views_send-7.x-1.x-dev.tar and I'm not getting the wysiwyg editor. This is a much needed addition i think.

benjarlett’s picture

benjarlett CreditAttribution: benjarlett commented
Status: Closed (fixed) » Needs review
benjarlett’s picture

benjarlett CreditAttribution: benjarlett commented

actually I just realised I'm using ckeditor instead... could support for this module be added too please? pretty please?

peerv’s picture

peerv CreditAttribution: peerv commented

I am getting Ckeditor in de body field of of the message form.
Just magicly!! Did not do anything special!

hansfn’s picture

hansfn CreditAttribution: hansfn commented
Status: Needs review » Closed (fixed)

Yes, you should get the wysiwyg editor your site is using automatically for the body field (message) since that field has text_format as type. Maybe caching caused it to not appear immediately for you?