New [Content Type Name] Button not Localized [#1506628]

I am running advanced forum on a multilingual site with English and Spanish. The New [Content Type Name] button only displays the default language content type name no matter what language you are viewing the site in. Tested on fresh install with same results. Modules used on fresh install:

Drupal 7.12
Advanced Forum 7.x-2.0
Views 7.x-3.3
Chaos tool suite (ctools) 7.x-1.0-rc2
Variable 7.x-1.1+19-dev
Internationalization 7.x-1.4+20-dev
Localization update 7.x-1.0-beta3

I made the Forum topic content type translatable and added a translation for content type name in Spanish but it does not display for the button when you visit the forum on the Spanish site. if you go to the node/add page the translation is working just fine.

Comment	File	Size	Author
#7	1506628.patch	619 bytes	BTMash
#7
#1	advanced_forum-node_type_name_i18n-1506628-1.patch	900 bytes	trigdog
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

trigdog CreditAttribution: trigdog commented 28 March 2012 at 16:13

Status:

Active

» Needs review

File	Size
advanced_forum-node_type_name_i18n-1506628-1.patch	900 bytes

Here is a patch that localizes the content type name with i18n_string_translate.

Comment #2

BTMash CreditAttribution: BTMash commented 28 March 2012 at 20:48

Michelle asked for a comment in here though as someone with old i18n experience...is there a reason to use i18n_string_translate over t()? t() seems like a more flexible option. Plus...doesn't something in i18n take over when passed through t() (that is what the string overrides module does)?

Comment #3

trigdog CreditAttribution: trigdog commented 28 March 2012 at 22:30

Agreed, I thought t() would work too. That is what I did first, but I couldn't get it to work. Maybe you can enlighten me :)

// Fetch the "General" name of the content type.
$node_type = node_type_get_name($type);
$node_type = t('@content_type', array('@content_type' => $node_type));

This still gives me just the default language (English) content type name ever if I am viewing the site in Spanish.

Comment #4

BTMash CreditAttribution: BTMash commented 28 March 2012 at 23:41

@trigdog, it should just be t($node_type) because the @content_type is taken as a placeholder that will come through without being translated. http://drupal.org/node/322732 has much more information on the topic.

Comment #5

Michelle

she/her

English

Wisconsin, USA

CreditAttribution: Michelle commented 29 March 2012 at 01:07

Status:

Needs review

» Needs work

Thanks for your help, BTMash. I've only done English sites so my localization knowledge is sketchy at best. It's sounding like this still needs some work so setting the status appropriately.

Comment #7

BTMash CreditAttribution: BTMash commented 29 March 2012 at 07:14

Status:

Needs work

» Needs review

File	Size
1506628.patch	619 bytes

Given that I **think** this should just get wrapped in a t() function (or maybe someone else has a better idea - there must be something I missed), attaching a patch.

Comment #8

Michelle

she/her

English

Wisconsin, USA

CreditAttribution: Michelle commented 29 March 2012 at 14:37

Hmm... I was curious why core didn't do this and went to see what was done there. Looks like it's change quite a bit from what I remember in D6. While adding t() here seems like it would work, I wonder if we should be considering all that core is doing here and if more of it should be copied to AF?

http://api.drupal.org/api/drupal/modules!forum!forum.module/function/for...

I'm going to defer to troky as he is more familiar with AF in D7 than I am (not to mention more likely than me to make actually do the committing ;) ). Just throwing that out there as a suggestion.