The first parameter for update_calculate_project_update_status() is $project. This variable is not used in the function at all. $project_data is used for everything, as it contains all the information for the project.

function update_calculate_project_update_status($project, &$project_data, $available) {
CommentFileSizeAuthor
#1 remove-unneeded-parameter-1505146-1.patch1.16 KBTor Arne Thune
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Tor Arne Thune’s picture

Tor Arne Thune CreditAttribution: Tor Arne Thune commented
Status: Active » Needs review
FileSize
remove-unneeded-parameter-1505146-1.patch1.16 KB

Remove it.

Tor Arne Thune’s picture

Tor Arne Thune CreditAttribution: Tor Arne Thune commented
Issue tags: +Novice

Marking this as novice for the review.

Tor Arne Thune’s picture

Tor Arne Thune CreditAttribution: Tor Arne Thune commented
Title: update_calculate_project_update_status() defines argument that it does not use. » Remove unused argument from update_calculate_project_update_status()
Barrett’s picture

Barrett CreditAttribution: Barrett commented
Status: Needs review » Reviewed & tested by the community

Patch applies cleanly. All Update and Update API tests pass following application. I was able to identify no calls to the function in question beyond those addressed by the patch.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed/pushed to 8.x

Automatically closed -- issue fixed for 2 weeks with no activity.