Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
remote import creates an ssh connection based on your local username, would it be possible to set this username based on the remote end's requirements instead?
With Aegir running locally on my OS X machine it uses the following:
Running: ssh -o PasswordAuthentication=no 'brian'@'host01.hostname.com' 'drush @hostmaster '\''status'\'' --backend 2>&1' 2>&1
which should instead be:
Running: ssh -o PasswordAuthentication=no 'aegir'@'host01.hostname.com' 'drush @hostmaster '\''status'\'' --backend 2>&1' 2>&1
Comment | File | Size | Author |
---|---|---|---|
#17 | interdiff-1503712-12-16.txt | 3.99 KB | colan |
#12 | remote_import-add-ssh-user-input-3.patch | 4.07 KB | gval |
Comments
Comment #1
Steven Jones CreditAttribution: Steven Jones commentedThis is actually a provision bug: #1504120: Script user of remote servers is ignored
Comment #2
Steven Jones CreditAttribution: Steven Jones commentedOnce that provision issue is fixed, we should present an option in the UI to change the script user on the remote server.
Comment #3
Steven Jones CreditAttribution: Steven Jones commentedSo I fixed the upstream bug, so we should be able to support this in Aegir 1.9 and above.
Comment #4
mxmilkiib CreditAttribution: mxmilkiib commentedThis would be handy for moving from a Barracuda to an Octopus install.
Might it be possible to add a field for a non-standard SSH port also?
Comment #5
helmo CreditAttribution: helmo at Initfour websolutions for Aegir Cooperative commentedmoving....
Comment #6
colanIncorporating #4.
Comment #7
gval CreditAttribution: gval as a volunteer and commentedHi,
I'm using some servers with differents usernames (o1, o2, dev1,...),
so i have made a patch to choose a custom username on server config page.
See attached file.
Comment #8
helmo CreditAttribution: helmo at Initfour websolutions for Aegir Cooperative commentedThanks for looking into this.
These should probably be empty() instead of isset(). When you clear the new field it would otherwise use an empty string as username.
Comment #9
gval CreditAttribution: gval as a volunteer and commentedYes, you're right.
I've replaced "isset" by "!empty" to avoid an empty string as username.
Comment #10
colanComment #11
colanI haven't tested this, but I took a quick look at the code. Yes, thanks for working on this.
Extra whitespace is appearing on these blank lines. (8 lines from 29 to 84.)
Bad indentation.
Comment #12
gval CreditAttribution: gval as a volunteer and commentedNew patch (v3.10)
Comment #13
colanComment #14
helmo CreditAttribution: helmo at Initfour websolutions for Aegir Cooperative commentedApart from the two trivial updates below it looks sane, but I haven't got time to test it properly.
@colan, can we get it rtbc by Thursday? Then I can include it it 3.11
whitespace bug
debug?
Comment #15
colanIf there's a new patch available shortly, I should be able to test it by then (at least ensuring that it doesn't break anything).
Comment #17
colanFixed coding standards violations. See interdiff for details.
As this doesn't appear to break existing functionality, I committed it.
Set status back so we can work on adding support for custom ports (or any follow-up commits if the new functionality needs tweaking).
Comment #18
cvining CreditAttribution: cvining commentedCustom ports would be handy, and a bit more secure. For me, remote imports is a very helpful (when migrating to a new server, for example) but not every day. So, I just switch my SSH server back to port 22 for the imports and return to a custom port when I'm done.
Thanks for all the fish!