The latest code has a number of new bug fixes and features, including some we want, specifically. We should update. Also, right now some of our components are 2.0, some are 2.1-dev. Oops. :-)

CommentFileSizeAuthor
#9 symfony-update.patch310.89 KBBTMash
#3 symfony-update.patch310.94 KBCrell
#1 symfony-update.patch310.94 KBCrell
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Crell’s picture

Crell CreditAttribution: Crell commented
Status: Active » Needs review
FileSize
symfony-update.patch310.94 KB

Here's a patch. Please note in the commit message that this is commit c4dfe931f1ce8827f8c02975bc0ab405bdc8d27c out of Symfony. (That way we can track it later.)

Status: Needs review » Needs work

The last submitted patch, symfony-update.patch, failed testing.

Crell’s picture

Crell CreditAttribution: Crell commented
Status: Needs work » Needs review
FileSize
symfony-update.patch310.94 KB

Don't you talk smack about my patch format, bot!

Status: Needs review » Needs work

The last submitted patch, symfony-update.patch, failed testing.

Crell’s picture

Crell CreditAttribution: Crell commented
Status: Needs work » Needs review

#3: symfony-update.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, symfony-update.patch, failed testing.

Crell’s picture

Crell CreditAttribution: Crell commented
Status: Needs work » Needs review

#3: symfony-update.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, symfony-update.patch, failed testing.

BTMash’s picture

BTMash CreditAttribution: BTMash commented
Status: Reviewed & tested by the community » Needs review
FileSize
symfony-update.patch310.89 KB

When I opened the patch, it was showing up in dos format and applying it was causing some funkiness. I've converted it to unix format (yay for http://kb.iu.edu/data/acux.html) and the patch now applies cleanly on my machine. I've not tested it out (I'm not following the WSCCI initiative as closely as I probably should be) but I'm attaching patch that hopefully applies cleanly on testbots.

As a note, this is a simple reroll of the patch by @crell - please do not add me to the list of contributors for credit authorship.

Crell’s picture

Crell CreditAttribution: Crell commented
Status: Needs work » Reviewed & tested by the community

How in the name of Druplicon did DOS characters get in there???

Oh well. Bot likes it, so I do, too.

pdrake’s picture

pdrake CreditAttribution: pdrake commented
Status: Needs review » Reviewed & tested by the community

This patch applies cleanly for me and is passing tests so far (tests always run a bit slow for me, so it hasn't finished yet). RTBC

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks!

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Fixed » Reviewed & tested by the community

This does not actually appear to have been committed.

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia commented
Assigned: Unassigned » Dries

Dries might have forgotten to push, so assigning to him.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

I pushed everything now. Please re-open if that is still not the case.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.