Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
From \Drupal\taxonomy\TermBreadcrumbBuilder::build()
// @todo This overrides any other possible breadcrumb and is a pure hard-coded
// presumption. Make this behavior configurable per vocabulary or term.
Comment | File | Size | Author |
---|---|---|---|
#28 | 1495510-nr-bot.txt | 132 bytes | needs-review-queue-bot |
#12 | 1495510-12.patch | 1.87 KB | andypost |
Comments
Comment #1
jhedstromThis patch doesn't make the behavior configurable, but it fixes the issue where
taxonomy_term_page()
was overriding breadcrumbs that had already been set by another module.Comment #2
jhedstromOops. Had the logic backwards there.
Comment #3
Sborsody CreditAttribution: Sborsody commentedFor what it's worth, reposting my opinion on breadcrumbs from http://drupal.org/node/723694#comment-3061402
The patch in #2 is a good start. The only drawback is that there's no way to get a taxonomy breadcrumb without unsetting whatever is currently set. It would be infinitely useful if modules returned a breadcrumb or part of a breadcrumb to a caller.
Comment #4
andypost#2: 1495510-02-taxonomy-term-page-breadcrumb.patch queued for re-testing.
Comment #5
firebird CreditAttribution: firebird commentedHere's a patch that allows switching the taxonomy module defined breadcrumbs on/off per vocabulary. This allows the use of any custom breadcrumbs on taxonomy term pages without them getting overridden.
Comment #7
firebird CreditAttribution: firebird commentedThe tests fail, seemingly because of the database schema change. What should I do to remedy that?
Comment #8
jibranThis is not a problem in D8 anymore we can service with high priority and override the behavior
taxonomy_term_page
page is also converted to view in D8.So moving to D7.
Comment #9
jibranThe @todo is moved to
\Drupal\taxonomy\TermBreadcrumbBuilder::build()
This is still an issue in D8 so moving back to D8 queue.
#1905370: Add missing vocabulary to fix term edit form breadcrumbs and #2400543: Breadcrumb should be term name instead of term id on term edit and delete page are also related.
Comment #10
dawehnerMh, any contrib module can just remove the service and be done or replace the service or what not, or even just use a higher priority.
I don't see that as an implementation problem, and we don't need configuration per vocabulary, as this seems to be quite a limited usecase, if you have hierarchy, you
want it to be present.
Comment #11
jibranThat what I said in #8 but we need a patch here anyway to remove the @todo if we are not going to fix it. Or we can update the comment for contrib modules.
Comment #12
andypostWe have another implementation in forum module already so let's just link them.
So it's not a bug for 8.x
Suppose we just need them, or maybe extend comment
Comment #13
jibranAwesome. We now need a beta eval.
Comment #14
siva_epari CreditAttribution: siva_epari commentedComment #21
stefan.kornI came across this ToDo and wanted to use the Default Path Based Breadcrumb Builder on Taxonomy terms too.
As I understand from this issue, the ToDo is not going to be done in Drupal 8 Core. So I put the a module Taxonomy Path Breadcrumb together, which enables users to configure per vocabulary whether to use taxonomy breadcrumb builder or path based breadcrumb builder.
Comment #28
needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commentedThe Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.