Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I've run into a problem when using libraries such as Uniform to skin my form elements. I noticed however that the select all/none wasn't actually selecting all/none of the checkboxes (except the first one) after they were skinned. After taking a look at BEF's JS code I found that, indeed, only the first checkbox was actually being triggered for a change event. The notes in the code suggest a complete browser lockup otherwise. I would like to mention that may be true, if you don't used jQuery's selection contexts. I will apply the patch shortly.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 1495504-bef-checkbox-change-event-1.patch | 3.02 KB | markhalliwell |
Comments
Comment #1
markhalliwellAttaching patch.
Comment #2
markhalliwellAny word on this?
Comment #3
mikeker CreditAttribution: mikeker commentedMark, my apologies for taking so long to get back to you.
However, the attached patch doesn't work when Autosubmit is turned on. It doesn't change the link text and leaves only the first item in the list checked.
Just to clarify, the reason other JS libraries don't work with select all/none is because they are relying on the checkboxes change event? I wonder if it may be easier to turn off the Autosubmit event handler, check/uncheck all the checkboxes (and fire their change events) and then autosubmit... Just thinking out loud.
Comment #4
Neslee Canil PintoHi, there will be no more future development for 7.x branch. If you see this issue in 8.x, feel free to file an issue. Closing this as Closed(wont fix).