Revisioning and Organic Groups Access Control - requires rebuild perms all the time [#1494232]

Is this possible? I have a dev server where Revisioning is broken and I'm not sure why. It was previously working and I'm not sure if installing other contrib modules is what broke it. The Author and Moderator roles cannot see content unless they are given the "Bypass content access control" permission. I would like to remove Revisioning completely and install it again to get past this problem.

Comments

Comment #1

RdeBoer

Melbourne

CreditAttribution: RdeBoer commented 22 March 2012 at 21:52

Sad to hear you're looking at uninstalling Revisioning rather than whatever this other module is.... :-(

Anyway, if you want to go down this path, you're in luck.
Revisioning does very little to the database. The main thing is that tickbox on the the content types "New revision in draft, pending moderation".
That's all you lose when you uninstall Revisioning. In fact, if you untick that box without uninstalling Revisioning, things may already snap into place.

If that doesn't sufficiently work disable the module and then uninstall it like any other.

You won't lose any content.

Make a backup though. This module does that for you with one click. Then you can restore later (with two clicks). It's sooo easy to use: Backup and Migrate.

Comment #2

jh81 CreditAttribution: jh81 commented 23 March 2012 at 16:01

Don't be sad! I don't want to uninstall Revisioning at all I'm just trying to troubleshoot the problems. Revisioning is a key component of one site we've already deployed. It is also key to the next site we are going to deploy but we are having issues with it. Can't seem to nail down what module is interfering with it. I've read in some other post that modules that deal with access permissions (like Content Access) can cause issues with Revisioning. The only modules we're using that deal with access permissions are Forum Access and Organic Groups.

So we tried uinstalling and re-installing Revisioning and that made no difference. Tried uninstalling Forum Access (since it doesn't really do what we need it to) and that made no difference. No we are trying to install Revisioning and Organic Groups on a clean implementation of Drupal 7 to see if they can co-exist. We can't go without either module so I'm hopeful that test works and it was something else on our development server.

Still really would like a way to figure out what is wrong with our implementation of Revisioning. If we give an account "Bypass content access control" then they have no problems seeing revisions created by others but we can't deploy with that enabled. If we Rebuild Permissions then that makes the problem go away until a new revision of the content is created. Its certainly something with view permissions as an authenticated users gets access denied when viewing the revisioned page, an account with rights to view others revisions can't see a revisioned page in the view and gets access denied when attempting to bring up that page. Strange.

Have been using Backup and Migrate and its come in handy!

Comment #3

jh81 CreditAttribution: jh81 commented 23 March 2012 at 19:10

Confirmed on a clean Drupal 7.8 installation that as soon as we enable Organic Groups module, we get the view issues with content that has revisions. Specifically its the Organic Groups Access Control module. If we disable that then Revisioning does work again. And of course a Rebuild Permissions temporarily fixes the problem.

Not sure if this is related to this issue -> http://drupal.org/node/1282084 but the description in the issue summary pretty much matches what we are seeing. Thinking about trying the patch in that link or seeing if we can get away with turning off the Organic Groups Access Control module.

Comment #4

RdeBoer

Melbourne

CreditAttribution: RdeBoer commented 24 March 2012 at 23:57

Title:

How do I uninstall Revisioning and remove all content from being revisioned

» Revisioning and Organic Groups Access Control - requires rebuild perms all the time

Hi John,
The relevant patches from that thread, #1282084: Revisioning may not be compatible with certain modules that use hook_node_access_records() (e.g. Domain Access), have already been incorporated 7.x-1.x-dev, so I suggest you give the recent dev version a spin, as I'm about to make that the stable release and would appreciate you feedback before I do.

Not guaranteeing at all it will solve the Revisioning/OG Access combo, as OG Access has traditionally been a trouble child....

Changing title.

By the way, isn't time to update to D7.12 ?

Comment #5

jh81 CreditAttribution: jh81 commented 26 March 2012 at 17:07

We tried the latest dev version but that still didn't provide a complete fix. The patch and the dev version fix the issue for published nodes but do not fix the issue for unpublished nodes. It looks to us like the patch handles rebuilding permissions when a revision is published. A complete fix would rebuild permissions anytime a revision is created or edited. We're going to attempt to do that ourselves but any help you can provide would be greatly appreciated. Even if its just pointing us to the places in the code where revisions are created or edited. Thanks for your help and support!

Comment #6

RdeBoer

Melbourne

CreditAttribution: RdeBoer commented 26 March 2012 at 21:10

New revisions are created and/or modified (if revision_moderation is not enabled for the node type) in core's node_save() function. This calls hook_node_save(), i.e. revisioning_node_save(..), so you may want to look at implementing that.

Just prior to saving the node/revision revisioning_node_update() and revisioning_node_presave() are called by core, but I don't think those would be the right place to do what you're aiming for.

Good luck! Let me know how you're going.

Comment #7

jh81 CreditAttribution: jh81 commented 27 March 2012 at 16:23

We took a look at the code and being Drupal newbies (although we have software development background), I don't think we're up to making those changes. We tried inserting the code in a few areas and horribly broke things.

It really comes down Organic Groups Access Control for some strange reason. If it is enabled then reviewers can't see unpublished revisions that authors created. If we disable it, like magic, they can see them.

As a side bar we also tried adjusting the weights of the modules but that did not work.

For now as a workaround we are going to give reviewers the Bypass Access Control permission. Not good because it allows them to delete revisions. Also they won't be able to use the revisioning_content_summary view as that also seems to be affected. But they can see the unpublished pages in the built in content page (admin/content). Not the best solution but short of going with something else beside Revisioning (which we don't want to do) it seems to be our only option.