I'm going to link to #1468582: Add mobile friendly meta tags to the html.tpl.php to save repetition.

CommentFileSizeAuthor
#1 bartik-mobile-meta-tags-1488756-1.patch2.27 KBLewisNyman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
Issue tags: +mobile
FileSize
bartik-mobile-meta-tags-1488756-1.patch2.27 KB

This patch is based on Dan's patch in #1468582: Add mobile friendly meta tags to the html.tpl.php

switzern’s picture

switzern
Primary language English
Location Denver, CO
CreditAttribution: switzern commented
Status: Active » Reviewed & tested by the community

This patch has been tested and it looks to working correctly. Tested on desktop, iOS and Android browser.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Needs review

I'm not sure about putting these in hook_html_head_alter(). That primarily exists for altering existing tags, not for adding new ones.
Seems like they could also be added in hook_page_alter() using #attached, which runs a lot earlier. Or what about hook_preprocess_html()?

I'm moving this back to CNR rather than code needs work - I'm not sure the best place for this to live, especially considering this will likely be done in all core themes (which presumably contrib themes will be expected to follow) it'd be good to understand why more.

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Status: Needs review » Closed (duplicate)

Thanks, Catch! Your comment kicked off a new discussion about how to do this in the best way for themers and module devs. It's a compromise, but a good one.

I'm closing this in favor of a unified approach in #1468582: Add mobile friendly meta tags to the html.tpl.php