In the initial CMI patch, the following config files were created for the image module

image.styles.large.xml
image.styles.medium.xml
image.styles.small.xml

These should really be changed to singular (aka style instead of styles.) To do this the following has to happen:

- The files need to be renamed
- Anywhere in code that references 'image.styles.*' needs to be changed to 'image.style.*'

Files: 
CommentFileSizeAuthor
#9 1479652-09.patch2.59 KBjhedstrom
FAILED: [[SimpleTest]]: [MySQL] 35,642 pass(es), 9 fail(s), and 1 exception(s). View
#1 1479652-1.patch3.42 KBPsikik
PASSED: [[SimpleTest]]: [MySQL] 35,629 pass(es). View

Comments

Psikik’s picture

FileSize
3.42 KB
PASSED: [[SimpleTest]]: [MySQL] 35,629 pass(es). View

First go at a patch. Renames the files and changes all instances of image.styles in image.module to image.style when using the new config system.

Psikik’s picture

Status: Active » Needs review

Forgot to set status.

heyrocker’s picture

Status: Needs review » Reviewed & tested by the community

This is perfect! Tests pass, I ran it locally a bit and everything checks out. Thanks!

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Nice little clean-up. Committed to 8.x.

aspilicious’s picture

Priority: Normal » Critical
Status: Fixed » Active

I think you forgot to add the new files?

moshe weitzman’s picture

We wouldn't forget to add files if folks used format-patch instead of patch. And folks would get proper attribution. We have documented the process at http://drupal.org/node/1054616. I think that should be the default. Another huge advantage is that patches will apply much more often even when underlying code has changed since git knows the ancestry when the patch was rolled and can be more aggressive in applying.

jhodgdon’s picture

Status: Active » Reviewed & tested by the community

I reverted the commit above because it was missing files. Back to RTBC.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Sorry about missing those files.

jhedstrom’s picture

Status: Fixed » Needs review
FileSize
2.59 KB
FAILED: [[SimpleTest]]: [MySQL] 35,642 pass(es), 9 fail(s), and 1 exception(s). View

Looks like the old files are still there. Patch removes them.

Status: Needs review » Needs work

The last submitted patch, 1479652-09.patch, failed testing.

jhedstrom’s picture

Hmm, doesn't look like the patch from #1 was actually committed?

jhedstrom’s picture

Status: Needs work » Reviewed & tested by the community

Setting this back to RTBC. It looks like the original patch was reverted, and then only the new files were added, without the necessary code changes.

catch’s picture

Status: Reviewed & tested by the community » Fixed

OK this should be fixed now, I got confused between what needed to be added vs. deleted, so the git history is a bit of a mess now (took three commits to get straight), but code should be in the right state afaik.

Automatically closed -- issue fixed for 2 weeks with no activity.