Get Skeleton is a mobile friendly, responsive base theme. It is clean and light weight, while providing a basis for theme developers to develop sub themes that will be fit for the mobile era. It is based on the Skeleton boilerplate (http://www.getskeleton.com) .

Get Skeleton has a 960 pixel grid system and is very easy to develop grid based designs. It also includes preset styles for buttons, tabs, forms. Media queries are used to scale the grid to the device (iPhone, Android phone, tablet, laptop, large screen etc).

Development of Get Skeleton will closely follow the Skeleton boilerplate with the addition of Drupal specific enhancements. The goal is that the Get Skeleton theme is the theme to use for people who want to use the Skeleton boilerplate in Drupal.

Name: Get Skeleton
Sandbox URL: http://drupal.org/sandbox/blairski/1405578
Intended Drupal core version: 7.x

CommentFileSizeAuthor
#2 drupalcs-result.txt101.6 KBnalan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

patrickd’s picture

patrickd CreditAttribution: patrickd commented
Status: Active » Needs review

welcome,

needs review -> please read about the application workflow

while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxblairski1405578git

You can also get a review bonus and we will come back to your application sooner.

regards

nalan’s picture

nalan CreditAttribution: nalan commented
FileSize
drupalcs-result.txt101.6 KB

Hi,
I just took a look at your theme, it looks good. Coming to colours, i found the entire theme in black and white, are there any reason for being like this? Then there are some coding style issues that you'll have to take care of

Automatic review :
Review of the 7.x-1.x branch:

* Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Manual review:
1) Please add a screenshot file in your theme. You also need to indicate it in the info file.
2) The favicon is placed in the images folder is not working. By default drupal favicon is displaying.
3) In the readme could you also mention the compatibility with different browsers.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Needs review » Needs work
guusbosman’s picture

guusbosman CreditAttribution: guusbosman commented

The Get Skeleton framework is published under the MIT license. There is an (unresolved) discussion about the license here: http://drupal.org/node/1214532

You might want to reach out to the author (hi@getskeleton.com) to see if he'd be willing to release it under GPL as well (http://davegamache.com/2011/05/skeleton-boilerplate/).

blairski’s picture

blairski CreditAttribution: blairski commented

i found the entire theme in black and white, are there any reason for being like this?

Because it is a base theme, I thought black and white was best so that I am not in any way forcing a style on anyone who wants to sub theme it.

I'll take care of the code style issues ASAP. I haven't replied until now as I have been holiday :)

blairski’s picture

blairski CreditAttribution: blairski commented

The Get Skeleton framework is published under the MIT license. There is an (unresolved) discussion about the license here: http://drupal.org/node/1214532

You might want to reach out to the author (hi@getskeleton.com) to see if he'd be willing to release it under GPL as well (http://davegamache.com/2011/05/skeleton-boilerplate/).

That is interesting. I will get in touch with Dave Gamache and ask the question.

blairski’s picture

blairski CreditAttribution: blairski commented
Status: Needs work » Needs review

I have fixed the issues detected in the Drupal Code Sniffer. When running the Code Sniffer locally, there are no issues. ventral.org is still picking up one issue, but it is not an error, so I am not sure why it is picking it up.

The ventral.org issue is:
FILE: ...-7-pareview/sites/all/modules/pareview_temp/test_candidate/css/base.css
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
538 | ERROR | No style definition found on line; check for missing colon

The CSS is valid and to the Drupal standard on line 538

I have also fixed the issues found in the manual test by nalan:
1) Please add a screenshot file in your theme. You also need to indicate it in the info file.
2) The favicon is placed in the images folder is not working. By default drupal favicon is displaying.
3) In the readme could you also mention the compatibility with different browsers.

blairski’s picture

blairski CreditAttribution: blairski commented

In regards to the MIT license, I have emailed Dave Gamache (author of Skeleton). He is very happy with have Skeleton ported to Drupal and chose MIT because it is the most open and free license. He gave me his consent to do I please with Skeleton.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Assigned: Unassigned » klausi
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Assigned: klausi » Unassigned
Status: Needs review » Reviewed & tested by the community

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

  • Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards).
    
FILE: ...drupal-7/sites/all/modules/pareview_temp/test_candidate/scripts/tabs.js
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 26 | ERROR | Expected 1 space before "=="; 0 found
 26 | ERROR | Expected 1 space after "=="; 0 found
--------------------------------------------------------------------------------

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

  1. tabs.js: appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms. The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.

But that are not application blockers, otherwise looks RTBC.

patrickd’s picture

patrickd CreditAttribution: patrickd commented
Assigned: Unassigned » patrickd
patrickd’s picture

patrickd CreditAttribution: patrickd commented
Status: Reviewed & tested by the community » Fixed

Your project page is not very detailed, please have a look at the tips for a great project page, you may also use HTML-tags for better structure.

Also a demo page or screenshot would be nice, anyways,

Thanks for your contribution!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.