Drat. I screwed up in #1371298: Rewrite .info files inside drush make when checking out from git to include version and project info since I wasn't handling core version strings differently than contrib. :( So, drush make is getting very confused about version strings resulting in stuff like this when you checkout core via Git using drush make:

; Information added by drush on 2012-03-08
version = ""
project = "drupal"
datestamp = "1331277327"

I see where the bug is, and am working on a patch now. Just wanted to open an issue about it.

CommentFileSizeAuthor
#2 1474778-2.make-core-versions.patch2.43 KBdww
#1 1474778-1.make-core-versions.patch2.5 KBdww
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Status: Active » Needs review
FileSize
1474778-1.make-core-versions.patch2.5 KB

This works. It's bigger than it looks because I needed to nest the existing code 2 spaces deeper since it's now an else clause.

We should add tests, but I'm not sure if that belongs over at #1433304: Add tests for .info file rewriting and fancy -dev version strings or here...

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
FileSize
1474778-2.make-core-versions.patch2.43 KB

Whoops, my copy of drush was stale. This should apply cleanly to the tip of the master branch...

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented
Status: Needs review » Fixed

Committed with small changes to comment formatting. Thanks!

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented

Let's add tests in #1433304: Add tests for .info file rewriting and fancy -dev version strings.

Automatically closed -- issue fixed for 2 weeks with no activity.