Hi there. I'm not super familiar with the inner workings of VBO, and I apologize if this bug report is rather vague as I have yet to be able to totally isolate the problem.
When I enabled devel's backtrace debug functionality and try to add a bulk operations field to a view, an ajax error is thrown. Trying to add the VBO field or adjust its settings in the views ui throws the error. Going to the settings form without ajax produces the settings page, but with the following error:
Warning: Missing argument 3 for views_bulk_operations_modify_action_views_bulk_operations_form(), called in /Applications/MAMP/htdocs/merlin/sites/all/modules/views_bulk_operations/plugins/operation_types/action.class.php on line 159 and defined in views_bulk_operations_modify_action_views_bulk_operations_form() (line 501 of /Applications/MAMP/htdocs/merlin/sites/all/modules/views_bulk_operations/actions/modify.action.inc). =>
I've looked at views_bulk_operations_modify_action_views_bulk_operations_form, it takes 3 arguments. When the function is called, however,
$settings_form_callback = $this->operationInfo['callback'] . '_views_bulk_operations_form';
if (function_exists($settings_form_callback)) {
$settings = $this->getAdminOption('settings', array());
$form['settings'] = array(
'#type' => 'fieldset',
'#title' => t('Operation settings'),
'#collapsible' => TRUE,
'#dependency' => array(
$dom_id . '-selected' => array(1),
),
);
$form['settings'] += $settings_form_callback($settings, $this->entityType);
only two arguments are passed. Adding in the 3rd argument, $dom_id, removes the error for me. Maybe this is a coding error? patch attached.
Comment | File | Size | Author |
---|---|---|---|
settings_form_missing_argument.patch | 587 bytes | mkadin | |
Comments
Comment #1
bojanz CreditAttribution: bojanz commentedNow that's a stupid bug. I have no idea how it took that long for it to be discovered. Committed a slightly tweaked fix, thanks for reporting!