openid.install still has a function openid_update_6000() in it in Drupal 8.x. It shouldn't be there, should it? If it belongs there for some other purpose, it should be renamed.

CommentFileSizeAuthor
#13 openid-update_6000-1461572-13.patch1.41 KBizus
#6 openid-update_6000-1461572-6.patch1.41 KBunderq
#3 openid-update_6000-1461572-3.patch1.34 KBunderq
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Component: documentation » openid.module

I must have put this in the doc component by force of habit... :)

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Issue tags: +Novice

Tagging novice.

underq’s picture

underq CreditAttribution: underq commented
Status: Active » Needs review
FileSize
openid-update_6000-1461572-3.patch1.34 KB

The Patch

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

Nice

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Needs work

We should implement hook_update_last_removed() in openid.install as well.

underq’s picture

underq CreditAttribution: underq commented
Status: Needs work » Needs review
FileSize
openid-update_6000-1461572-6.patch1.41 KB

With implement of hook_update_last_removed().

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Needs work

Never heard of this...

Documentation: http://api.drupal.org/api/drupal/modules%21system%21system.api.php/funct...

The number for 7.x should be 6000, but do we need this in 8.x?

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs work » Needs review

It should be fine to leave it at whichever the last update was.

Jody Lynn’s picture

Jody Lynn
she/her
Primary language English
CreditAttribution: Jody Lynn commented
Status: Needs review » Reviewed & tested by the community

Reviewed. Looks good.

Dries’s picture

Dries CreditAttribution: Dries commented

Patch doesn't seem to apply so asking for a re-test.

Dries’s picture

Dries CreditAttribution: Dries commented
Issue tags: -Novice

#6: openid-update_6000-1461572-6.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work
Issue tags: +Novice

The last submitted patch, openid-update_6000-1461572-6.patch, failed testing.

izus’s picture

izus CreditAttribution: izus commented
Status: Needs work » Needs review
FileSize
openid-update_6000-1461572-13.patch1.41 KB

I tested to git apply the patch in #6 locally but failed, i applied it manually and generated a new patch. Hopefully it works now :)

Jody Lynn’s picture

Jody Lynn
she/her
Primary language English
CreditAttribution: Jody Lynn commented
Status: Needs review » Reviewed & tested by the community

Confirmed #13 applies and looks good.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.