I am supposing this is a webform issue since I noticed this behaviour after updating it, but I could be wrong.

After updating from 6.x-3.15 to 6.x-3.16 the email label does not seem to be processed correctly by compact forms (username and multiline text fields work just like before), was there any change to it?

CommentFileSizeAuthor
#30 email-field.jpg16.92 KBcrutch
#18 compact_forms_email_textfield-1459346-18.patch544 bytesdaveparrish
#8 compact_forms.js_.patch680 bytesfloydm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented

Yes, Webform uses a type="email" field instead of a type="text" field now. I'm guessing compact forms does not account for HTML5 elements yet.

castawaybcn’s picture

castawaybcn CreditAttribution: castawaybcn commented
Title: Compact form email not working » Email label not processed by compact form
quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented
Title: Email label not processed by compact form » Email labels in Webform 3.16+ not processed by compact form
Project: Webform » Compact Forms
Version: 6.x-3.16 » 6.x-1.3
castawaybcn’s picture

castawaybcn CreditAttribution: castawaybcn commented

thanks for moving the issue, quicksketch.

lasseitorp’s picture

lasseitorp CreditAttribution: lasseitorp commented

Jquery does not understand an 'input:email' psuedo-class. That's the main problem.

climbing-alien’s picture

climbing-alien CreditAttribution: climbing-alien commented
Version: 6.x-1.3 » 7.x-1.0
Priority: Normal » Major

Same problem. Are there any ways round it?

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented

Jquery does not understand an 'input:email' psuedo-class. That's the main problem.

jQuery should understand the selector "input[type=email]" though. I'm not familiar with the code of this module, but that additional selector seems like it could help.

floydm’s picture

floydm CreditAttribution: floydm commented
FileSize
compact_forms.js_.patch680 bytes

Yes, that selector takes care of it, at least in my case. Thank you, quicksketch.

Attached is a patch. Apologies if I'm not submitting this correctly, I'm fairly new to this.

-F

kettultim’s picture

kettultim CreditAttribution: kettultim commented

That worked beautifully. Thanks Floydm!

bcobin’s picture

bcobin CreditAttribution: bcobin commented

Tried it - worked like a charm... thanks much!

satter9’s picture

satter9 CreditAttribution: satter9 commented

Yeah, works great! Thanks for submitting.

Cristobal Wetzig’s picture

Cristobal Wetzig CreditAttribution: Cristobal Wetzig commented

Thank you for the patch!

jday’s picture

jday CreditAttribution: jday commented

Patch worked for me, Thank You!!

Drupal Centric’s picture

Drupal Centric CreditAttribution: Drupal Centric commented

Patch worked for me D7.12, Webform 7.x-3.17 and Compact Forms 7.x-1.0 thanks.

ac’s picture

ac
Primary language English
Location Perth
CreditAttribution: ac commented
Status: Active » Reviewed & tested by the community

Please commit this - it is a very simple fix and solves the problem.

tars16’s picture

tars16 CreditAttribution: tars16 commented

Patch also works for me.

joecanti’s picture

joecanti CreditAttribution: joecanti commented

+1 - patch worked for me

Thanks! Joe

daveparrish’s picture

daveparrish CreditAttribution: daveparrish commented
FileSize
compact_forms_email_textfield-1459346-18.patch544 bytes

Patch wouldn't work with drush make so I'm rerolling. Enjoy!

meishme’s picture

meishme CreditAttribution: meishme commented

#18 worked for me. Thanks.

Stan Turyn’s picture

Stan Turyn CreditAttribution: Stan Turyn commented

Guys, anyone know what's the name of password-confirm field on the registration form? (as in 'input:password' but for confirmation field - there is the same problem with it as with e-mail)

Boobaa’s picture

Boobaa
he/him
CreditAttribution: Boobaa commented

#18 works for me. Thanks.

MattHer’s picture

MattHer CreditAttribution: MattHer commented

#18 works for me for 6.x-1.3 Thanks

castawaybcn’s picture

castawaybcn CreditAttribution: castawaybcn commented

#18 is working for me too. Using 6.x-1.3 as well.

Thanks a lot for this.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Reviewed & tested by the community » Fixed

Thanks for reporting, reviewing, and testing! Committed to 7.x-1.x.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

NickWebman’s picture

NickWebman CreditAttribution: NickWebman commented

Hi,

Thanks for the patch. The label appears appropriately now, but it does not change opacity when it's clicked. Is anyone else experiencing this?

Thanks,
Nick

EDIT: Sorry - user error. Nevermind.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

joachim’s picture

joachim CreditAttribution: joachim commented
Version: 7.x-1.0 » 6.x-1.x-dev
Status: Closed (fixed) » Needs review

can we get this committed to 6.x pleasE?

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs review » Reviewed & tested by the community

Patch applies and works perfectly on D6.

jive01’s picture

jive01 CreditAttribution: jive01 commented

I can confirm the #18 works.

crutch’s picture

crutch CreditAttribution: crutch commented
FileSize
email-field.jpg16.92 KB

works for 7.x-1.10

after these updates yesterday

list erased


then the email label is outside the field. Then only difference I see is that the email field has no class .compact-form-wrapper like the others

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
CreditAttribution: xurizaemon commented

This looks like a duplicate of #1405834: HTML5 new field input type support, and the patch there looks like a more complete solution (which may need a tiny bit of backporting to apply to D6).

Fix here solves only email fields, but #1405834: HTML5 new field input type support brings in email AND tel, url, number, range, date, time, datetime, month, week, colour and search. Let's do that please?

yannickoo’s picture

yannickoo
Location Berlin
CreditAttribution: yannickoo commented
Status: Reviewed & tested by the community » Closed (duplicate)

This *is* a duplicate of #1405834: HTML5 new field input type support, so let us close this issue and move to the other one. The patch will be backported after it will be applied to the 7.x-1.x branch.

madelyncruz’s picture

madelyncruz CreditAttribution: madelyncruz commented

#8 Works properly. Thanks dude!